CI: Adding initial workflow #4

andy5995 · 2024-11-18T22:03:55Z

No description provided.

andy5995 · 2024-11-18T22:24:36Z

meson.build

-    default_options: ['c_std=gnu23', 'cpp_std=gnu++23'],
+    version: '0.1.0-dev',
+    meson_version: '>= 1.1',
+    default_options: ['c_std=gnu2x', 'cpp_std=gnu++23'],


meson.build:1:0: ERROR: None of values ['gnu23'] are supported by the C compiler. Possible values for option "C_std" are ['none', 'c89', 'c99', 'c11', 'c17', 'c18', 'c2x', 'gnu89', 'gnu99', 'gnu11', 'gnu17', 'gnu18', 'gnu2x']

I think you are using an "outdated" compiler.
I am making explicit use of the #embed preprocessor directive which has been set standard with C23 (and as such covered by gnu23).
Any prior version is unlikely to work.
On my system, and on the flatpak I am using clang-19 for that reason.
You might be able to also use very recent zig (it is just an updated clang frontend in C/C++ mode).

If you look at project.json,

"meson-setup.clang-release": "meson setup --reconfigure build/ --buildtype=release --native-file toolchains/clang.ini"

I am using a specific native file to ensure that c23 is supported.
This is briefly discussed in: https://github.com/KaruroChori/vs-fltk/blob/master/docs/for-developers.md

Understood. I made some changes. Please trigger the workflow when it's convenient.

andy5995 · 2024-11-18T22:25:23Z

meson.build

@@ -1,7 +1,9 @@
 project(
    'vs-fltk',
    ['c', 'cpp', 'swift'],
-    default_options: ['c_std=gnu23', 'cpp_std=gnu++23'],
+    version: '0.1.0-dev',
+    meson_version: '>= 1.1',


Build type: native build
WARNING: Project does not target a minimum version but uses feature introduced in '1.1': meson.options file. Use meson_options.txt instead

KaruroChori · 2024-11-19T11:48:00Z

Failing with these relevant parts in the log

2024-11-19T11:23:26.0866261Z | CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
2024-11-19T11:23:26.0867351Z | Please set them or make sure they are set and tested correctly in the CMake files:
2024-11-19T11:23:26.0868383Z | /home/runner/work/vs-fltk/vs-fltk/subprojects/libfltk/src/OPENGL_INCLUDE_DIR
2024-11-19T11:23:26.0869671Z | used as include directory in directory /home/runner/work/vs-fltk/vs-fltk/subprojects/libfltk/src
2024-11-19T11:23:26.0870843Z | used as include directory in directory /home/runner/work/vs-fltk/vs-fltk/subprojects/libfltk/src

2024-11-19T11:23:26.0894581Z | CMake Error in src/CMakeLists.txt:
2024-11-19T11:23:26.0895341Z | Target "fltk_gl" INTERFACE_INCLUDE_DIRECTORIES property contains path:
2024-11-19T11:23:26.0896120Z 
2024-11-19T11:23:26.0896596Z | "/home/runner/work/vs-fltk/vs-fltk/subprojects/libfltk/src/OPENGL_INCLUDE_DIR-NOTFOUND"
2024-11-19T11:23:26.0897295Z 
2024-11-19T11:23:26.0897640Z | which is prefixed in the source directory.

and a second one virtually identical.
Some of the system dependencies are not satisfied while building fltk. For example in flatpak I had to manually add glu.
An apt install freeglut3-dev might solve it here as well.

KaruroChori · 2024-11-19T12:26:14Z

Yes, that was the issue.
I also updated the last command which only made sense when run on the machine of a developer, but not in the actual pipeline.

There are now compiling errors of code I wrote which I cannot locally replicate.
I think that has to do with the gnu library being used (include/x86_64-linux-gnu/c++/12/, include/x86_64-linux-gnu/c++/14/)

For KaruroChori#6

This reverts commit 79c9e22.

Attempt to add freeglut3-dev since this was also the issue when building the flatpak

Replaced vs.example with the actual meson command; otherwise, if successful, the machine would run the application without headless mode, and wait for user input.

.github/workflows/build.yml

Co-authored-by: Andy Alt <[email protected]>

KaruroChori · 2024-11-19T21:21:41Z

It looks like the gnu lib shipped in ubuntu-22.04 is fully missing some header files like <format> and possibly more.
On 24.04 instead instead there is a totally different failure of libfltk. I will have to investigate what is going on.

KaruroChori · 2024-11-19T21:59:37Z

Well it looks like the culprit is the newest verison of cmake mesonbuild/meson#13888
3.31.0 vs 3.30.3 I am using on all my machines.

For mesonbuild/meson#13888

KaruroChori · 2024-11-20T07:07:25Z

Success on ubuntu-24.04!

Only keeping 24.04 for now, since the other versions ship with an older incompatible libc++

andy5995 commented Nov 18, 2024

View reviewed changes

andy5995 force-pushed the ci/add-initial branch 3 times, most recently from 6412b0c to 3efe5ab Compare November 19, 2024 08:17

KaruroChori pushed a commit that referenced this pull request Nov 19, 2024

Partial fix I for #4. More is likely needed

3be362e

andy5995 and others added 15 commits November 19, 2024 14:34

CI: Adding initial workflow

834b34b

Add required meson version

fcd7c49

Add temporary project version

aa86f9b

Use gnu2x for c_std instead of gnu23

111beec

build.yml: Add more deps

31f7a08

meson.build: Try to find installed sqlite{3,cpp}

0ae33fa

For KaruroChori#6

Use clang, reset c_std=gnu23, install bun

9447848

Install clang-19

116f64e

Use "bun run meson-setup clang-release"

06ce04c

Revert "Use "bun run meson-setup clang-release""

f55a6cb

This reverts commit 79c9e22.

Fix version

a6a14ba

remove blank line

04748cf

Add path filters

80dab32

Update build.yml

1653c86

Attempt to add freeglut3-dev since this was also the issue when building the flatpak

Update build.yml

e581b31

Replaced vs.example with the actual meson command; otherwise, if successful, the machine would run the application without headless mode, and wait for user input.

andy5995 force-pushed the ci/add-initial branch from 88b916f to e581b31 Compare November 19, 2024 20:34

andy5995 commented Nov 19, 2024

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

Update .github/workflows/build.yml

2b88030

Co-authored-by: Andy Alt <[email protected]>

KaruroChori and others added 2 commits November 19, 2024 22:14

Update build.yml

a6f00b6

Try to install cmake 3.30.5

5579420

For mesonbuild/meson#13888

Install libpng-dev

a9b83e3

andy5995 force-pushed the ci/add-initial branch from 31e7e55 to a9b83e3 Compare November 20, 2024 06:57

Update build.yml

b1ddeeb

Only keeping 24.04 for now, since the other versions ship with an older incompatible libc++

KaruroChori merged commit 51dc003 into KaruroChori:master Nov 20, 2024

KaruroChori added the build-system label Nov 20, 2024

KaruroChori added this to the v0.1.1-alpha milestone Nov 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI: Adding initial workflow #4

CI: Adding initial workflow #4

andy5995 commented Nov 18, 2024

andy5995 Nov 18, 2024

KaruroChori Nov 19, 2024 •

edited

Loading

andy5995 Nov 19, 2024

andy5995 Nov 18, 2024

KaruroChori commented Nov 19, 2024 •

edited

Loading

KaruroChori commented Nov 19, 2024

KaruroChori commented Nov 19, 2024

KaruroChori commented Nov 19, 2024 •

edited

Loading

KaruroChori commented Nov 20, 2024

CI: Adding initial workflow #4

CI: Adding initial workflow #4

Conversation

andy5995 commented Nov 18, 2024

andy5995 Nov 18, 2024

Choose a reason for hiding this comment

KaruroChori Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

andy5995 Nov 19, 2024

Choose a reason for hiding this comment

andy5995 Nov 18, 2024

Choose a reason for hiding this comment

KaruroChori commented Nov 19, 2024 • edited Loading

KaruroChori commented Nov 19, 2024

KaruroChori commented Nov 19, 2024

KaruroChori commented Nov 19, 2024 • edited Loading

KaruroChori commented Nov 20, 2024

KaruroChori Nov 19, 2024 •

edited

Loading

KaruroChori commented Nov 19, 2024 •

edited

Loading

KaruroChori commented Nov 19, 2024 •

edited

Loading