-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JSON parsing in koji.js #828
Conversation
It can happen that JSON files have a special encoding character at the beginning, this check would prevent loading the json. we already use try/catch here
Really this shouldn't be happening here at all but rather in the load geofence where proper config loader has already been called |
Then the workflow has to be completly changed, true? So you mean we should not load the config json in that place |
This is a hack to load config early, outside of the real config loader (which handles all these issues) |
I'm fine to bring this process internally, but I would need help with it as I couldn't get it to work nicely with the rest of the codebase. |
@jfberry could we merge that fix until we find a better solution pls? :) |
The fix you have taken out was introduced because it was crashing |
weird it's not crashing for me with that change. so we have several cases. and we definitely have to fix/rework the way how we use koji |
It was a specific user who could not start poracle |
There is a try/catch which should do it's job.... I will reopen the issue again |
Description
It can happen that JSON files have a special encoding character at the beginning, this check would prevent loading the json. we already use try/catch here
Motivation and Context
I want to use Koji with Poracle (both in docker)
fixes #827
How Has This Been Tested?
Bearer token is now detected after that change
Screenshots (if appropriate):
Types of changes
Checklist: