-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests config for serialization of arrays #279
Conversation
Expected. The fix is not in the released JDK 22 Mandrel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected. The fix is not in the released JDK 22 Mandrel
And it's not going to get backported to it, so we probably need to disable it in that configuration.
testsuite/src/it/java/org/graalvm/tests/integration/AppReproducersTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Foivos <[email protected]>
I see, indeed. Lemme update it... |
Eh.. Failing now on this PR:
Exclusions in the test: @Test
@Tag("builder-image")
@IfMandrelVersion(min = "23.1.5", maxJDK = "21.999", inContainer = true)
public void forSerializationContainer21Test(TestInfo testInfo) throws IOException, InterruptedException {
forSerialization(testInfo, Apps.FOR_SERIALIZATION_BUILDER_IMAGE);
}
@Test
@IfMandrelVersion(min = "23.1.5", maxJDK = "21.999")
public void forSerialization21Test(TestInfo testInfo) throws IOException, InterruptedException {
forSerialization(testInfo, Apps.FOR_SERIALIZATION);
}
@Test
@Tag("builder-image")
@IfMandrelVersion(min = "23.1.5", minJDK = "23", inContainer = true)
public void forSerializationContainer23Test(TestInfo testInfo) throws IOException, InterruptedException {
forSerialization(testInfo, Apps.FOR_SERIALIZATION_BUILDER_IMAGE);
}
@Test
@IfMandrelVersion(min = "23.1.5", minJDK = "23")
public void forSerialization23Test(TestInfo testInfo) throws IOException, InterruptedException {
forSerialization(testInfo, Apps.FOR_SERIALIZATION);
} I am probably blind... or it's parsing Mandrel 24 as JDK 24? |
The logs say
so it doesn't look like a parsing issue. I think the issue is that you are passing "21.999" as the Line 46 in 9f6c895
|
Depends on [GR-52473] Serialization of arrays is not supported in Native Image oracle/graal#8509 being released via Backport: Allow custom constructors for arrays and enums graalvm/graalvm-community-jdk21u#10
Depends on [GR-57707] native-image-agent omits String[] from "serialization" when using newConstructorForSerialization oracle/graal#9581 being fixed, backported and released.
Merging it now would trigger failures for CI.