-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for Calendar building. #221
Conversation
Re: CI failures. They all seem caused by the new test (at least for 22.3) which needs: graalvm/mandrel#616 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as the warning like https://github.com/Karm/mandrel-integration-tests/actions/runs/6850877756/job/18625960493?pr=221#step:7:27515 are going to be fixed by graalvm/mandrel#616 (or whitelisted)?
Please merge after graalvm/mandrel#616 gets merged and the tests on this PR go green.
Thanks @jerboaa
bf7fa93
to
f812ed2
Compare
Good catch. I forgot to
OK. Waiting on the CI to complete on that one first. |
@zakkak On second thought. PR testers use released |
You are right. Sure go ahead and merge when ready. |
I'll see if I can add some conditional logic to only run it on 22.3.5 or so and better. |
testsuite/src/it/java/org/graalvm/tests/integration/AppReproducersTest.java
Show resolved
Hide resolved
f812ed2
to
dc8a50d
Compare
Should now only run for
And skipped with a
|
Related to quarkusio/quarkus#36975