Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] JFR integration tests fail for Mandrel for JDK 23 - JDK events initialization #268

Closed
jerboaa opened this issue Jul 1, 2024 · 6 comments

Comments

@jerboaa
Copy link
Collaborator

jerboaa commented Jul 1, 2024

Latest Mandrel integration tests fail the JFR integration test with this warning:

[warn][jfr,system] Could not initialize JDK events. jfrTracing

... which usually indicates a larger problem, so we should investigate.

Example test output:

Error:    JFRTest.jfrOptionsSmokeTest:784->jfrOptionsSmoke:922 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel/mandrel/mandrel-integration-tests/testsuite/target/archived-logs/org.graalvm.tests.integration.JFRTest/jfrOptionsSmokeTest/build-and-run.log and check these offending lines: 
[warn][jfr,system] Could not initialize JDK events. jfrTracing ==> expected: <true> but was: <false>
Error:    JFRTest.jfrPerfTest:185->jfrPerfTestRun:234 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel/mandrel/mandrel-integration-tests/testsuite/target/archived-logs/org.graalvm.tests.integration.JFRTest/jfrPerfTest/build-and-run.log and check these offending lines: 
[warn][jfr,system] Could not initialize JDK events. jfrTracing

See this CI link:
https://github.com/graalvm/mandrel/actions/runs/9720067442/job/26831418361#step:11:20582

@jerboaa
Copy link
Collaborator Author

jerboaa commented Jul 1, 2024

@roberttoyonaga Could you please take a look at this? Thanks!

@jerboaa
Copy link
Collaborator Author

jerboaa commented Jul 1, 2024

Seems related to https://bugs.openjdk.org/browse/JDK-8331876 new in JDK 23+26.

@jerboaa
Copy link
Collaborator Author

jerboaa commented Jul 1, 2024

It doesn't seem to be happening for a Mandrel build with JDK 24+3. Looks like we'd need a backport of oracle/graal#9212

@jerboaa
Copy link
Collaborator Author

jerboaa commented Jul 1, 2024

Steps to reproduce:

export JAVA_HOME=/path/to/mandrel-build-based-on-jdk23
export GRAALVM_HOME=$JAVA_HOME
export PATH=$JAVA_HOME/bin:$PATH
export FAIL_ON_PERF_REGRESSION=false
mvn clean verify -Dquarkus.version=999-SNAPSHOT -Ptestsuite -Dtest=JFRTest#jfrPerfTest

@roberttoyonaga
Copy link
Collaborator

@roberttoyonaga Could you please take a look at this? Thanks!

Yup I can look at this!

@jerboaa
Copy link
Collaborator Author

jerboaa commented Jul 5, 2024

No longer an issue. Fixed with graalvm/mandrel#762.

@jerboaa jerboaa closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants