Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.1] Add reflection metadata for jfrTracing field. #762

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[24.1] Add reflection metadata for jfrTracing field. #762

merged 1 commit into from
Jul 3, 2024

Conversation

roberttoyonaga
Copy link
Collaborator

@roberttoyonaga roberttoyonaga commented Jul 2, 2024 •
edited
Loading

(cherry picked from commit e816ad6)

Related issue: #761

Even with this backport, I'm able to intermittently reproduce the failure here: Karm/mandrel-integration-tests#268

I think there's more the the problem in Karm/mandrel-integration-tests#268. I'll look into this more.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 2, 2024
@zakkak zakkak added backport affects/JDK23 Affects JDK 23 based Mandrel affects/24.1 Mandrel for JDK 23 labels Jul 2, 2024
@jerboaa
Copy link
Collaborator

jerboaa commented Jul 2, 2024

Even with this backport, I'm able to intermittently reproduce the failure here: Karm/mandrel-integration-tests#268

OK then, we should probably wait with backporting it until it's fully resolved. WDYT?

@roberttoyonaga
Copy link
Collaborator Author

Even with this backport, I'm able to intermittently reproduce the failure here: Karm/mandrel-integration-tests#268

OK then, we should probably wait with backporting it until it's fully resolved. WDYT?

Yes let’s do that

@roberttoyonaga
Copy link
Collaborator Author

I must have not set updated the GRAALVM_HOME environment variable on that test run that failed. After rebuilding everything and starting from scratch, I'm not able to reproduce the problem, even after repeated attempts. I think the patch works fine to resolve the issue.

Failing GHA:

  • Mandrel-Quarkus tests / Q main M 24.1 EA / Q IT Data6 Looks unrelated. Seems related to hibernate.
  • Mandrel-Quarkus tests / Q main M 24.1 EA / Q IT Messaging1 Also seems unrelated. Related to an authentication failure io.quarkus.it.kafka.KafkaOauthIT.test
  • Mandrel-Quarkus tests / Q main M 24.1 EA / Q Mandrel IT
    Failed with:
    Error: Substitution target for com.oracle.svm.core.jfr.Target_jdk_jfr_internal_JVM_ChunkRotationMonitor is not loaded. Use field `onlyWith` in the `TargetClass` annotation to make substitution only active when needed.
    This is due to: Images with JFR will not build due to out of date substitution oracle/graal#9199 and probably requires another backport. I'll open another issue for this and assign myself to it.

@roberttoyonaga roberttoyonaga mentioned this pull request Jul 3, 2024
Closed
2 tasks
@roberttoyonaga roberttoyonaga changed the title Add reflection metadata for jfrTracing field. [24.1] Add reflection metadata for jfrTracing field. Jul 3, 2024
@roberttoyonaga roberttoyonaga mentioned this pull request Jul 3, 2024
Merged
zakkak
zakkak approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @roberttoyonaga

@zakkak
Copy link
Collaborator

zakkak commented Jul 3, 2024

The CI failures are indeed known and unrelated, see https://github.com/graalvm/mandrel/actions/runs/9751570325

@zakkak zakkak merged commit 5754033 into graalvm:mandrel/24.1 Jul 3, 2024
39 of 42 checks passed
@zakkak zakkak linked an issue Jul 3, 2024 that may be closed by this pull request
[24.1] Backport: [GR-54703] Add reflection metadata for jfrTracing field. #761
Closed
2 tasks
@jerboaa jerboaa mentioned this pull request Jul 5, 2024
Closed
@zakkak
Copy link
Collaborator

zakkak commented Jul 25, 2024 •
edited
Loading

Upstream backport PR oracle#9380

@zakkak
Copy link
Collaborator

zakkak commented Jul 30, 2024

This backport was dropped in favor of the upstream one oracle#9380 in c4639ba

@zakkak zakkak removed the backport label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakkak zakkak zakkak approved these changes

Assignees
No one assigned
Labels
affects/JDK23 Affects JDK 23 based Mandrel affects/24.1 Mandrel for JDK 23 OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[24.1] Backport: [GR-54703] Add reflection metadata for jfrTracing field.
4 participants
@roberttoyonaga @jerboaa @zakkak @jovanstevanovic