Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix translation for
kano-updater
and add Japanese translation.German translation would need to be revised, since some strings have changed.
Note: as noted earlier by @hzulla, the updater requires some changes in kano-toolset to handle unicode. See PR #221 in KanoComputing/kano-toolset.
The installer has been tested successfully on Kano with Japanese locale, but for the test, I had to comment out the code that auto-updates the updater (in kano_updater/commands/install.py), to avoid the kano-updater to be overwritten by the English package. At the end of the upgrade, after the final reboot,
kano-updater
itself is replaced by the latest official package, which proves it works :)Implementation note: for APT tasks, since we are getting the progress directly from apt-progress, the strings are localized. Therefore, we need to define the phase names by localizing them using the apt package translations. Doing this makes the phase name match and progress is reported correctly.