Shifted all emoji data in a json file #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Ezio-Sarthak
commented
Oct 19, 2020
Ezio-Sarthak
commented
- Dumped emoji ids and names into JSON file (issue Shift emoji ids and names to a json file #143 resolved)
- Shifted data of emojify.js to elient.js
- deleted emojify.js
- Dumped emoji ids and names into JSON file - Shifted data of emojify.js to elient.js - deleted emojify.js
LalitNM
requested changes
Oct 19, 2020
LalitNM
changed the title
- Onclick corrected for emojis - corrected footer imports
|
@Ezio-Sarthak you might want to have a look at this. |
LalitNM
approved these changes
Oct 21, 2020
This was referenced Oct 21, 2020
LalitNM
added a commit
to LalitNM/baat-cheet
that referenced
this pull request
Oct 27, 2020
Changes done - Dumped emoji ids and names into JSON file - Shifted emoji adding code from emojify.js to elient.js - deleted emojify.js Co-authored-by: Lalit Narayan Mudgal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.