Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #117

Closed
LalitNM opened this issue Oct 11, 2020 · 12 comments
Closed

Refactor #117

LalitNM opened this issue Oct 11, 2020 · 12 comments

Comments

@LalitNM
Copy link
Member

LalitNM commented Oct 11, 2020

At present there is some unnecessary code in each file. You are supposed to remove that unnecessary code.

Tasks:

  • Remove unnecessary code(of JS as well as CSS).

  • Wherever possible replace code like

anotherElement.innerHTML = '<element id="someID" class="someClass">Some text</element>';

with code like

element = document.createElement("element");
element.classList.add("someClass");
element.id = "someID";
element.innerText = "Some Text";
anotherElement.innerHTML = element;

Most important thing is to create separate commit for each file.

@bineetNaidu
Copy link
Contributor

I would like to Contribute onto this project .. Feel free to assign me this task.

@LalitNM
Copy link
Member Author

LalitNM commented Oct 11, 2020

Go ahead @bineetNaidu, I assigned this to you.

@kpbot
Copy link
Member

kpbot commented Oct 15, 2020

Hello @DEEPA-CHERI, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 7 days.

You can reclaim this issue or claim any other issue by commenting @kpbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@bineetNaidu
Copy link
Contributor

Hello @bineetNaidu, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 4 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 3 days.

If you've decided to work on something else, simply comment @kpbot abandon so that someone else can claim it and continue from where you left off.

@kpbot abandon

@LalitNM
Copy link
Member Author

LalitNM commented Oct 15, 2020

Some changes have been done by @bineetNaidu, Now this issue is open for further changes.

@DEEPA-CHERI
Copy link
Collaborator

@kpbot claim

@kpbot
Copy link
Member

kpbot commented Oct 16, 2020

Welcome to KamandPrompt, @DEEPA-CHERI! We just sent you an invite to collaborate on this repository at https://github.com/KamandPrompt/baat-cheet/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to KamandPrompt!

Here's some tips to get you off to a good start:

See you on the other side (that is, the pull request side)!

@DEEPA-CHERI
Copy link
Collaborator

Hi, it seems permission to push is denied for me.

@LalitNM
Copy link
Member Author

LalitNM commented Oct 18, 2020

Yeah, in order to contribute you are supposed to make a pull request.

@LalitNM LalitNM changed the title Remove unnecessary code Refactor Oct 19, 2020
@DEEPA-CHERI
Copy link
Collaborator

DEEPA-CHERI commented Oct 20, 2020

Hi, In order to raise pull request need to push the code into the branch right?

@LalitNM
Copy link
Member Author

LalitNM commented Oct 20, 2020

Yeah and read our contributing guidelines.

@LalitNM
Copy link
Member Author

LalitNM commented Oct 27, 2020

Duplicate at #159.

@LalitNM LalitNM closed this as completed Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants