Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Application Folder #5 #11

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

Stormbreakerr20
Copy link
Contributor

B22115_LuvSharma
issue #5
created application folder along with DSA and Ml algo folder in it adding 1 Algorithm to each one of them of respective domains

Initialised DSA and ML algo folders adding heapify algo to DSA and PCA preprocessing to ML
Added DSA algo and Ml algo to each of the folder in application folder
@CodingWarrior33
Copy link
Contributor

CodingWarrior33 commented Oct 4, 2023

@Stormbreakerr20 thanks a lot for taking out some time to contribute to the repository.

However , you seem to have misunderstood the directory structure.

Here is the structure

  1. Computational Algorithms
  2. ML algorithms
  3. Applications

.... 1) and 2) are for base algorithms , i.e if you want to create the heapify algorithm , you should create a folder called Heaps in the Computational Algorithms directory , and then create the heapifying.cpp codefile within it. Similar process should be followed for ML Algorithms.

The Applications Folder should contain the visualisation or real world example of the algorithm you created in the Computational Algorithm or the ML Algorithm directory. Hope this helps .....

@Stormbreakerr20
Copy link
Contributor Author

Got it, I will update it

Added Ml, Application folder with Computational Algorithms
Added Application of KNN
@Stormbreakerr20
Copy link
Contributor Author

I have updated the structure as per the requirements....

@Stormbreakerr20
Copy link
Contributor Author

Are there any changes required?

@CodingWarrior33
Copy link
Contributor

@Stormbreakerr20, Thanks Again !!

Just update with the current version of the repository structure and change the python notebooks to python files. Also mention the links to csv in the code instead of adding the file directly.

@Stormbreakerr20
Copy link
Contributor Author

I have updated the folder structure, have contributed for Heaps only.

@CodingWarrior33
Copy link
Contributor

@Stormbreakerr20 looks good. Do contribute further !! Merging now .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants