forked from coinbase/temporal-ruby
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get latest from upstream #6
Open
longkt90
wants to merge
20
commits into
Kaligo:master
Choose a base branch
from
coinbase:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add schedule model classes These are meant to be the interface that users will have to use - I tried to copy as much useful documentation from the temporal grpc api as I could * Add serializers to convert model objects to proto * Add create, describe and list schedules * Delete and update schedule * Trigger and pause schedule * Add methods and Schedule module to Temporal obj * Remove unrelated spec Co-authored-by: Jeff Schoner <[email protected]> --------- Co-authored-by: Jeff Schoner <[email protected]>
* Remove cancelation commands when underlying futures are closed * Fix spec for timer command preservation * Remove potentially flaky example spec
Convert keyword argument into hashes in order to fulfill Temporal::Metrics API contract obligations. Fixes: #90 Signed-off-by: Progyan Bhattacharya <[email protected]>
* Add base64 to gemspec for Ruby 3.4.0 * Fix not to raise expectations to stop warning
* Allow passing channel args to GRPC connection * Add config.connection_options hash * Add option for client grpc connection retries * Allow passing custom gRPC retry policy
* Update README * Add heading
* Testing build with readme change * Sleep longer * Pin Temporal to version 1.22 * Remove test changes * Nit
) * Bump `dry-types`/`dry-struct` example versions The current versions in the examples are pretty old. * Use `Dry::Struct` instead of `Dry::Struct::Value` The gem is warning that `Dry::Struct::Value` is finally going to be removed. ``` [dry-struct] Dry::Struct::Value is deprecated and will be removed in the next major version /Users/sal/Development/temporal-ruby/lib/temporal/concerns/typed.rb:35:in `generate_struct' ```
Raise NotImplementedError instead of NoMethodError for clarify.
* Specialize workflow event targets * Methods for downloading histories * Replay tester * Basic replay tester unit tests * Add example replay test with history file * Add workflow stack trace to replay error * Dynamically load replay state in workflow logger * Log when replaying in replay tests * Use binpb extension for protobuf biniaries * Better comments about logging during replay * Simplify file -> bytes read calls * Fix comment typos * More ergonomic replaying callback * Improve ReplayTesterError, rubyfmt spec * Remove extra commands check * Don't default to logging in replay tests * Check history starts correctly * Remove correct_event_types * Refactor to more composable API * Use real namespace from configuration * rubyfmt * Fix test name typo
* Add pagination to get_workflow_history * Fix CI
…Apple Silicon machines (#310) * relax the version requirement for 'google-protobuf' to allow using newer 'grpc' gem * use major.minor to have min minor version requirement
* support passing activity task rate limit on worker options * remove extra space in README
* Implement ConverterWrapper as a replacement for Concern::Payloads * Wrap concerter & payload codec with ConverterWrapper in Configuration * Use ConverterWrapper in Connection::GRPC * Fix failing specs * Remove Concerns::Payload from worker and client * Remove Concerns::Payloads dependency from all the serializers * Remove Concerns::Payloads from Metadata * fixup! Remove Concerns::Payloads dependency from all the serializers * Remove Concerns::Payloads from Errors * Remove Concerns::Payloads from Executions * Remove Concerns::Payloads from fabricators * Remove Concerns::Payloads
* Remove global config from client specs * Remove global configuration from client and connection * Remove global configuration from integration specs * Remove global config from error messages and comments * Remove global config from specs * Remove global config from worker spec * Add README section on global vs local configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.