Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(panel controls): adjust padding on bulk actions #2023

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Nov 16, 2024

Description

In the panel controls component the bulk actions checkbox has incorrect padding when checked.
The PR corrects the padding.

Screenshots

Before After
Screenshot 2024-11-15 at 4 19 15 PM Screenshot 2024-11-15 at 4 03 17 PM

Testing in sage-lib

  • Navigate to Panel Controls
  • Click the bulk actions checkbox
  • Verify the padding is corrected.

Testing in kajabi-products

  1. (LOW) Updates padding of panel controls checkbox

Related

https://kajabi.atlassian.net/browse/DSS-1171

@pixelflips pixelflips self-assigned this Nov 16, 2024
@pixelflips pixelflips marked this pull request as ready for review November 16, 2024 00:17
@pixelflips pixelflips requested review from a team and QuintonJason November 16, 2024 00:17
@pixelflips pixelflips requested a review from a team November 16, 2024 00:20
@pixelflips
Copy link
Member Author

I applied a temp fix in KP to resolve the bug there. Will need to remove shim once bump is completed: https://github.com/Kajabi/kajabi-products/pull/38220

@pixelflips pixelflips merged commit 66fb3ec into develop Nov 16, 2024
7 checks passed
@pixelflips pixelflips deleted the style/bulk-actions-checked-spacing branch November 16, 2024 00:24
@pixelflips pixelflips mentioned this pull request Nov 16, 2024
@pixelflips pixelflips changed the title style: adjust padding on bulk actions style(panel controls): adjust padding on bulk actions Nov 16, 2024
ju-Skinner pushed a commit that referenced this pull request Nov 22, 2024
* style: adjust padding on bulk actions (#2023)

* style(empty state): add text wrap balance to empty state text (#2026)

* chore(deps): bump @pine-ds/icons from 8.10.0 to 8.11.0 (#2025)

Bumps [@pine-ds/icons](https://github.com/Kajabi/pine-icons) from 8.10.0 to 8.11.0.
- [Release notes](https://github.com/Kajabi/pine-icons/releases)
- [Changelog](https://github.com/Kajabi/pine-icons/blob/main/CHANGELOG.md)
- [Commits](Kajabi/pine-icons@v8.10.0...v8.11.0)

---
updated-dependencies:
- dependency-name: "@pine-ds/icons"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Monica Wheeler <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants