-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Badge: border and color updates #2022
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicawheeler
changed the title
style(badge): rework documentation and styles for border and color updates
Badge: border and color updates
Nov 22, 2024
ju-Skinner
approved these changes
Nov 25, 2024
pixelflips
approved these changes
Nov 25, 2024
monicawheeler
force-pushed
the
dss-1159-chip-border
branch
from
November 25, 2024 20:23
f4e09a3
to
a3b68ef
Compare
Dependency ReviewThe following issues were found:
License Issuesdocs/package.json
packages/sage-packs/package.json
packages/sage-react/package.json
Denied Licenses: LGPL-2.0, AAL, Adobe-2006, Afmparse, Artistic-1.0, Artistic-1.0-cl8, Artistic-1.0-Perl, Beerware, blessing, Borceux, CECILL-B, ClArtistic, Condor-1.1, Crossword, CrystalStacker, diffmark, DOC, EFL-1.0, EFL-2.0, Fair, FSFUL, FSFULLR, Giftware, HPND, IJG, Leptonica, LPL-1.0, LPL-1.02, MirOS, mpich2, NASA-1.3, NBPL-1.0, Newsletr, NLPL, NRL, OGTSL, OLDAP-1.1, OLDAP-1.2, OLDAP-1.3, OLDAP-1.4, psutils, Qhull, Rdisc, RSA-MD, Spencer-86, Spencer-94, TU-Berlin-1.0, TU-Berlin-2.0, Vim, W3C-19980720, W3C-20150513, Wsuipa, WTFPL, xinetd, Zed, Zend-2.0, ZPL-1.1, AGPL-1.0-only, AGPL-1.0-or-later, AGPL-3.0-only, AGPL-3.0-or-later, APSL-1.0, APSL-1.1, APSL-1.2, APSL-2.0, CPAL-1.0, EUPL-1.0, EUPL-1.1, EUPL-1.2, NPOSL-3.0, OSL-1.0, OSL-1.1, OSL-2.0, OSL-2.1, OSL-3.0, RPSL-1.0, SSPL-1.0, CAL-1.0, CAL-1.0-Combined-Work-Exception, Parity-6.0.0, Parity-7.0.0, RPL-1.1, RPL-1.5, EPL-1.0, EPL-2.0, ErlPL-1.1, IPL-1.0, LGPL-2.0-only, LGPL-2.0-or-later, LGPL-2.1-only, LGPL-2.1-or-later, LGPL-2.1, LGPL-3.0-only, LGPL-3.0-or-later, LGPL-3.0, MPL-1.0, MPL-1.1, MPL-2.0, MPL-2.0-no-copyleft-exception, MS-RL, SPL-1.0, BSD-Protection, copyleft-next-0.3.0, copyleft-next-0.3.1, GPL-1.0-only, GPL-1.0-or-later, GPL-1.0, GPL-2.0-only, GPL-2.0-or-later, GPL-2.0, GPL-3.0-only, GPL-3.0-or-later, GPL-3.0, QPL-1.0, Sleepycat Scanned Manifest Filesdocs/package.json
packages/sage-packs/package.json
packages/sage-react/package.json
|
Cam reviewed and approved this PR's 👍 |
monicawheeler
force-pushed
the
dss-1159-chip-border
branch
from
November 25, 2024 20:46
a3b68ef
to
5cbfb46
Compare
Merged
pixelflips
pushed a commit
that referenced
this pull request
Nov 26, 2024
* chore(ci): updating rails gem version [ci skip] * chore(release): publish [skip ci] * style(badge): rework documentation and styles for border and color updates * fix(linter): remove extra spaces and reorg style order * style(badge): rearrange badge preview and update styles * fix: linting issue in the scss for order of props * docs(badge): minor adjustments to grammar * style(dot): adjust sage-badge dot spacing to align with designs * revert versions to match develop * fix: remove extra space in changelog --------- Co-authored-by: Kajabi Automation Bot <[email protected]>
ju-Skinner
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Badge: border and color updates (#2022) * chore(ci): updating rails gem version [ci skip] * chore(release): publish [skip ci] * style(badge): rework documentation and styles for border and color updates * fix(linter): remove extra spaces and reorg style order * style(badge): rearrange badge preview and update styles * fix: linting issue in the scss for order of props * docs(badge): minor adjustments to grammar * style(dot): adjust sage-badge dot spacing to align with designs * revert versions to match develop * fix: remove extra space in changelog --------- Co-authored-by: Kajabi Automation Bot <[email protected]> * docs: update broken image paths (#2029) * chore(deps): bump @pine-ds/icons from 8.11.0 to 8.12.0 (#2028) Bumps [@pine-ds/icons](https://github.com/Kajabi/pine-icons) from 8.11.0 to 8.12.0. - [Release notes](https://github.com/Kajabi/pine-icons/releases) - [Changelog](https://github.com/Kajabi/pine-icons/blob/main/CHANGELOG.md) - [Commits](Kajabi/pine-icons@v8.11.0...v8.12.0) --- updated-dependencies: - dependency-name: "@pine-ds/icons" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Kajabi Automation Bot <[email protected]> Co-authored-by: Phillip Lovelace <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update badge to align with update to designs which request a border to be added to the sidebar.
Changes made
Screenshots
Gif
Testing in
sage-lib
Testing in
kajabi-products
Related
DSS-1159