Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: resolve logical properties issue with dropdown #2020

Merged
merged 3 commits into from
Nov 6, 2024
Merged

style: resolve logical properties issue with dropdown #2020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18d20e0
style: update physical properties to not use logical props
QuintonJason Nov 6, 2024
76337b3
Revert "style: update physical properties to not use logical props"
QuintonJason Nov 6, 2024
12b4b20
style: update incorrect logical properties
QuintonJason Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/sage-assets/lib/stylesheets/components/_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ $-btn-loading-min-height: rem(36px);
display: flex;
justify-content: center;
position: absolute;
inset-inline-start: 0;
inset-inline-end: 0;
width: $-btn-interactive-badge-icon-size;
margin: auto 0;
border-radius: 0 sage-border(radius-x-large) sage-border(radius-x-large) 0;
Expand Down Expand Up @@ -348,7 +348,7 @@ $-btn-loading-min-height: rem(36px);

.sage-panel-controls__toolbar-btn-group > &:not(.sage-btn--secondary) {
position: absolute;
inset-inline-start: 0;
inset-inline-end: 0;
inset-block-end: 0;
min-height: calc(#{$-btn-toolbar-group-height} + #{rem(2px)}); /* expand to toolbar group height + border offset */
}
Expand Down Expand Up @@ -438,18 +438,18 @@ $-btn-loading-min-height: rem(36px);
@include sage-icon-base(caret-down, md, pine);

position: absolute;
inset-inline-start: 1rem;
inset-inline-end: 1rem;
}

&[class*="icon-only"]::after {
@include sage-icon-base(caret-down, xs, pine);

inset-inline-start: $-btn-disclosure-left-padding;
inset-inline-end: $-btn-disclosure-left-padding;
font-weight: sage-font-weight(bold);
}

&[class*="icon-only"].sage-btn--small::after {
inset-inline-start: rem(12px);
inset-inline-end: rem(12px);
}

&:has(pds-icon) {
Expand All @@ -475,7 +475,7 @@ $-btn-loading-min-height: rem(36px);
}

&::after {
left: 7px;
right: 7px;
font-size: 11px;
font-weight: sage-font-weight(bold);
}
Expand Down Expand Up @@ -731,7 +731,7 @@ a.sage-btn {
// Remove class when Sage Label is fully deprecated in Products
.sage-label & {
position: absolute;
inset-inline-start: sage-spacing(xs);
inset-inline-end: sage-spacing(xs);
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions packages/sage-assets/lib/stylesheets/components/_dropdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ $-dropdown-trigger-dropdown-offset: rem(16px) + sage-spacing(xs);
}

.sage-dropdown--anchor-right > .sage-dropdown__panel & {
inset-inline-start: 0;
inset-inline-end: 0;
}

.sage-dropdown--small & {
Expand Down Expand Up @@ -359,7 +359,7 @@ $-dropdown-trigger-dropdown-offset: rem(16px) + sage-spacing(xs);
}

.sage-dropdown--anchor-right & {
inset-inline-start: 0;
inset-inline-end: 0;
}

.sage-dropdown--anchor-center & {
Expand Down
6 changes: 3 additions & 3 deletions packages/sage-assets/lib/stylesheets/components/_tooltip.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ $-tooltip-large-maxwidth: rem(320px);
.sage-tooltip--bottom {
&::after {
left: 50%;
right: 100%;
bottom: 100%;
transform: translate3d(-50%, 0, 0);
border-inline-start: $-tooltip-arrow-inactive;
border-inline-end: $-tooltip-arrow-inactive;
Expand All @@ -80,7 +80,7 @@ $-tooltip-large-maxwidth: rem(320px);
.sage-tooltip--left {
&::after {
left: 100%;
right: 50%;
bottom: 50%;
transform: translate3d(0, 50%, 0);
border-block-start: $-tooltip-arrow-inactive;
border-block-end: $-tooltip-arrow-inactive;
Expand All @@ -102,7 +102,7 @@ $-tooltip-large-maxwidth: rem(320px);
.sage-tooltip--right {
&::after {
left: 0;
right: 50%;
bottom: 50%;
transform: translate3d(-100%, 50%, 0);
border-block-start: $-tooltip-arrow-inactive;
border-block-end: $-tooltip-arrow-inactive;
Expand Down
Loading