Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(select): add optional help content area #1976

Merged
merged 4 commits into from
Sep 10, 2024
Merged

feat(select): add optional help content area #1976

merged 4 commits into from
Sep 10, 2024

Conversation

teenwolfblitzer
Copy link
Member

@teenwolfblitzer teenwolfblitzer commented Sep 10, 2024 •
edited
Loading

Description

When the message area of the Sage (Form) Select is in use, the ability to display contextual information for the field is limited. The most common occurrence is when the message area is used to display inline form validation errors

This branch adds a helpContent slot in React (help_content in Rails) adjacent to the label to free up the message area

Screenshots

Rails React
rails react

Testing in sage-lib

Testing in kajabi-products

  1. (LOW) New feature addition; no impact expected

Related

@teenwolfblitzer teenwolfblitzer self-assigned this Sep 10, 2024
@teenwolfblitzer teenwolfblitzer requested a review from a team September 10, 2024 17:36
pixelflips
pixelflips approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No concerns here. Thanks for taking this on!

ju-Skinner
ju-Skinner approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@ju-Skinner ju-Skinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teenwolfblitzer

@teenwolfblitzer teenwolfblitzer merged commit a87994a into develop Sep 10, 2024
7 checks passed
@teenwolfblitzer teenwolfblitzer deleted the kc_select_help_content branch September 10, 2024 19:23
@pixelflips pixelflips mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ju-Skinner ju-Skinner ju-Skinner approved these changes

@pixelflips pixelflips pixelflips approved these changes

@QuintonJason QuintonJason Awaiting requested review from QuintonJason

@FuturaExtraBold FuturaExtraBold Awaiting requested review from FuturaExtraBold

@anechol anechol Awaiting requested review from anechol

Assignees

@teenwolfblitzer teenwolfblitzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teenwolfblitzer @pixelflips @ju-Skinner