style: update color token name 3 digits #1955

QuintonJason · 2024-08-21T21:58:41Z

Description

update color name to use 3 digits instead of 2, mercury-500 instead of mercury-50

Screenshots

No visual changes

Testing in `sage-lib`

Click around the sage doc site and verify that there are no color visual regressions

Testing in `kajabi-products`

(Breaking) updates color tokens to use 3 digits instead of 2

Companion kp branch: https://github.com/Kajabi/kajabi-products/pull/36196/

First pass this looks good. However, I did notice we are still using two-digit token value in one area, 50, this should be changed to 050. It will also need to be updated in style-dictionary/tokens/color/base.json and docs/lib/sage_rails/app/sage_tokens/sage_dictionary.rb. The sage_dictionary file should be updated automatically when the base.json is fixed.

docs/app/views/pages/_color_values.html.erb

* style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter

This reverts commit 2f43f1d.

packages/sage-assets/lib/stylesheets/components/_breadcrumbs.scss

ju-Skinner · 2024-10-01T20:12:43Z

docs/lib/sage-frontend/stylesheets/docs/_colors.scss

+    // Determine class name for $value == 50
+    $classname: ".color-#{"" + $name}-#{$value}";
+    @if ($value == 50) {
+      $classname: ".color-#{"" + $name}-0#{$value}";
+    }
+
+    #{$classname} {


I had to add this because of how 050 was being treated. This will generate the class name .color-blue-050 instead of .color-blue-50, which is incorrect.

anechol

🚀

* fix(frame): add box shadow to bordered frame (#1958) * style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter * fix: change legacy colors to mapped values ie red 500 to red 95 * fix: remove old 100 tokens * fix: add 0 to make token 3 digits * fix: add red color classes * fix: add 0 to green color token names * fix: add 0 to blue color token names * fix: add 0 to mercury color token names * fix: add 0 to yellow color token names * fix: add 0 to purple color token names * fix: update grey color token names to 3 digits * fix: update react green colors * fix: update react purple colors * fix: update red in jsx and erb * fix: update orange color token to mercury * fix: update charcoal color token to upper greys * fix: update grey color token to lower greys * fix: add options for default color values * chore: remove whitespace * fix: self review fix grey 300 and grey 400 in css * Revert "fix: self review fix grey 300 and grey 400 in css" This reverts commit 2ae5967. * Revert "fix: update grey color token to lower greys" This reverts commit 69f8706. * fix: update grey color token to lower greys * Revert "fix: update grey color token to lower greys" This reverts commit 2f43f1d. * style: update purple color token to use three digits * style: update additional 2 digit token value to 3 digit token values * style: added zero to mercury 30 * style: update templating to wrap 050 values in single-quotes * style(breadcrumbs): change charcoal 400 to grey 900 * fix: update gray to grey instances --------- Co-authored-by: Julian Skinner <[email protected]>

style: update size of font in table (#1986) style: convert focus to focus-within (#1985) style: update color token name 3 digits (#1955) * fix(frame): add box shadow to bordered frame (#1958) * style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter * fix: change legacy colors to mapped values ie red 500 to red 95 * fix: remove old 100 tokens * fix: add 0 to make token 3 digits * fix: add red color classes * fix: add 0 to green color token names * fix: add 0 to blue color token names * fix: add 0 to mercury color token names * fix: add 0 to yellow color token names * fix: add 0 to purple color token names * fix: update grey color token names to 3 digits * fix: update react green colors * fix: update react purple colors * fix: update red in jsx and erb * fix: update orange color token to mercury * fix: update charcoal color token to upper greys * fix: update grey color token to lower greys * fix: add options for default color values * chore: remove whitespace * fix: self review fix grey 300 and grey 400 in css * Revert "fix: self review fix grey 300 and grey 400 in css" This reverts commit 2ae5967. * Revert "fix: update grey color token to lower greys" This reverts commit 69f8706. * fix: update grey color token to lower greys * Revert "fix: update grey color token to lower greys" This reverts commit 2f43f1d. * style: update purple color token to use three digits * style: update additional 2 digit token value to 3 digit token values * style: added zero to mercury 30 * style: update templating to wrap 050 values in single-quotes * style(breadcrumbs): change charcoal 400 to grey 900 * fix: update gray to grey instances --------- Co-authored-by: Julian Skinner <[email protected]> style: update hover color (#1991) style: adjust box shadow (#1992) style: update hint font-size (#1994) fix: adjust token color (#1995) fix: adjust token color (#1997)

BREAKING CHANGE: This is a breaking change due to the rebranding effort ci: update rebrand mercury workflow for deployments revert(font-weight): combine font-weights back to *00 based fix: DSS-752 style(letter-spacing): updates to letter spacing for medium and smaller (#1922) fix: DSS-747 Co-authored-by: Julian Skinner <[email protected]> style: update body-xs to 12px (#1926) refactor: removes page scope empty state and updates styles style: adds styles for Icon Card for default and compact variants style: adds gradient to icon card and empty state docs: removes unneeded examples and adds new props refactor: removes gradient refactor: renames scope prop to size chore: fixes Story name refactor: adds background color to icon docs: updates Empty States docs pages for Rails and React docs: updates React component description with better clarity chore: fixes linting issues chore: removes unneeded gradient references style(alert): adjust small variant icon alignment (#1930) style(checkbox): adjust checkbox margin for alignment (#1931) style(dropdown): add display flex to dropdown trigger (#1934) * style(dropdown): add display flex to dropdown trigger * style(dropdown): reorder css property style(badge): correct interactive icon size (#1935) style(line-height): update line-height to have rem units (#1933) fix(p): remove adjacent p tag spacing (#1936) fix: add white background color to box-like elements * fix(box-shadow): update box shadow token value * fix(box like components): add white background and md box shadow * fix(container): remove color and shadow from container * fix(css): updated order * fix(frame): update to fix background color with nested frames * fix(frame): add white background to bordered variant chore: adds scope prop to address spec failures chore: fixes syntax error fix: add panel box-shadow (#1944) * fix: add box-shadow to panel * fix: remove box-shadow from inner card and panels fix: updates placeholder assets & styles (#1947) * fix: add new image assets * style: adjust page heading image bg color * fix: add new image assets for storybook * fix: convert unsplash images to placeholders * fix: convert unsplash images to small placeholder * fix: hello linter my old friend * fix: update image in empty state fix: update line-height tokens (#1951) fix: update box shadows (#1952) * fix: update box shadows * fix: add space after comma ci: revert rebrand-mercury-rising back to original workflow this is done since release-deploy has been fixed. We hopes this solves this branch from not deploying properly in staging style(pagination): remove background color (#1956) style(choice): correct icon alignment (#1957) * style(choice): remove incorrect margin styles * docs(choice): add additional example without subtext fix(sortable): update template columns (#1960) fix(frame): add box shadow to bordered frame (#1958) style(tab): adjust tab underline variable value (#1959) chore: update pine-ds/icons to latets version fix: updates conditionals to make image optional (#1965) style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter style: change the active tab color to mercury 50 (#1969) Co-authored-by: Julian Skinner <[email protected]> style: focus state updates (#1970) * style: update sage-focus-ring mixin * style: update focus-outline colors * fix: removes duplicate focus ring * style: update focus colors and sizing * style: adjust tab focus * fix: replace named color for linter style(alert): add borders (#1972) style(progress): update the default fill color to mercury-50 (#1971) Co-authored-by: Julian Skinner <[email protected]> style(button): change border radius to 9999px (#1973) Co-authored-by: Julian Skinner <[email protected]> style: update spacer to use logical properties (#1968) style(button): change the colors for the accent variant to be purple (#1974) Co-authored-by: Julian Skinner <[email protected]> feature(loader): change loader to new behavior and colors (#1975) * feat(loader-rails): change the loader animation and fill color * feat(loader-react): change the loader animation and fill color * style(loader): change timing to 1.5s per convo with design team --------- Co-authored-by: Julian Skinner <[email protected]> style: updates button font family style: add Faire Spring font family (#1980) Co-authored-by: Julian Skinner <[email protected]> style(button): change button font-weight to med (500) (#1984) Co-authored-by: Julian Skinner <[email protected]> fix(button): loading button wasn't animating, updated svg in button-spinner.js (#1987) Co-authored-by: Julian Skinner <[email protected]> feat: v1.1 rebrand style: update size of font in table (#1986) style: convert focus to focus-within (#1985) style: update color token name 3 digits (#1955) * fix(frame): add box shadow to bordered frame (#1958) * style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter * fix: change legacy colors to mapped values ie red 500 to red 95 * fix: remove old 100 tokens * fix: add 0 to make token 3 digits * fix: add red color classes * fix: add 0 to green color token names * fix: add 0 to blue color token names * fix: add 0 to mercury color token names * fix: add 0 to yellow color token names * fix: add 0 to purple color token names * fix: update grey color token names to 3 digits * fix: update react green colors * fix: update react purple colors * fix: update red in jsx and erb * fix: update orange color token to mercury * fix: update charcoal color token to upper greys * fix: update grey color token to lower greys * fix: add options for default color values * chore: remove whitespace * fix: self review fix grey 300 and grey 400 in css * Revert "fix: self review fix grey 300 and grey 400 in css" This reverts commit 2ae5967. * Revert "fix: update grey color token to lower greys" This reverts commit 69f8706. * fix: update grey color token to lower greys * Revert "fix: update grey color token to lower greys" This reverts commit 2f43f1d. * style: update purple color token to use three digits * style: update additional 2 digit token value to 3 digit token values * style: added zero to mercury 30 * style: update templating to wrap 050 values in single-quotes * style(breadcrumbs): change charcoal 400 to grey 900 * fix: update gray to grey instances --------- Co-authored-by: Julian Skinner <[email protected]> style: update hover color (#1991) style: adjust box shadow (#1992) style: update hint font-size (#1994) fix: adjust token color (#1995) fix: adjust token color (#1997) docs: fix foundations color page fix: correct progress color tokens (#1998) * fix: correct color tokens * docs: update value in react story fix: update token value (#1999)

* feat!(rebrand): mercury-rising rebrand effort BREAKING CHANGE: This is a breaking change due to the rebranding effort ci: update rebrand mercury workflow for deployments revert(font-weight): combine font-weights back to *00 based fix: DSS-752 style(letter-spacing): updates to letter spacing for medium and smaller (#1922) fix: DSS-747 Co-authored-by: Julian Skinner <[email protected]> style: update body-xs to 12px (#1926) refactor: removes page scope empty state and updates styles style: adds styles for Icon Card for default and compact variants style: adds gradient to icon card and empty state docs: removes unneeded examples and adds new props refactor: removes gradient refactor: renames scope prop to size chore: fixes Story name refactor: adds background color to icon docs: updates Empty States docs pages for Rails and React docs: updates React component description with better clarity chore: fixes linting issues chore: removes unneeded gradient references style(alert): adjust small variant icon alignment (#1930) style(checkbox): adjust checkbox margin for alignment (#1931) style(dropdown): add display flex to dropdown trigger (#1934) * style(dropdown): add display flex to dropdown trigger * style(dropdown): reorder css property style(badge): correct interactive icon size (#1935) style(line-height): update line-height to have rem units (#1933) fix(p): remove adjacent p tag spacing (#1936) fix: add white background color to box-like elements * fix(box-shadow): update box shadow token value * fix(box like components): add white background and md box shadow * fix(container): remove color and shadow from container * fix(css): updated order * fix(frame): update to fix background color with nested frames * fix(frame): add white background to bordered variant chore: adds scope prop to address spec failures chore: fixes syntax error fix: add panel box-shadow (#1944) * fix: add box-shadow to panel * fix: remove box-shadow from inner card and panels fix: updates placeholder assets & styles (#1947) * fix: add new image assets * style: adjust page heading image bg color * fix: add new image assets for storybook * fix: convert unsplash images to placeholders * fix: convert unsplash images to small placeholder * fix: hello linter my old friend * fix: update image in empty state fix: update line-height tokens (#1951) fix: update box shadows (#1952) * fix: update box shadows * fix: add space after comma ci: revert rebrand-mercury-rising back to original workflow this is done since release-deploy has been fixed. We hopes this solves this branch from not deploying properly in staging style(pagination): remove background color (#1956) style(choice): correct icon alignment (#1957) * style(choice): remove incorrect margin styles * docs(choice): add additional example without subtext fix(sortable): update template columns (#1960) fix(frame): add box shadow to bordered frame (#1958) style(tab): adjust tab underline variable value (#1959) chore: update pine-ds/icons to latets version fix: updates conditionals to make image optional (#1965) style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter style: change the active tab color to mercury 50 (#1969) Co-authored-by: Julian Skinner <[email protected]> style: focus state updates (#1970) * style: update sage-focus-ring mixin * style: update focus-outline colors * fix: removes duplicate focus ring * style: update focus colors and sizing * style: adjust tab focus * fix: replace named color for linter style(alert): add borders (#1972) style(progress): update the default fill color to mercury-50 (#1971) Co-authored-by: Julian Skinner <[email protected]> style(button): change border radius to 9999px (#1973) Co-authored-by: Julian Skinner <[email protected]> style: update spacer to use logical properties (#1968) style(button): change the colors for the accent variant to be purple (#1974) Co-authored-by: Julian Skinner <[email protected]> feature(loader): change loader to new behavior and colors (#1975) * feat(loader-rails): change the loader animation and fill color * feat(loader-react): change the loader animation and fill color * style(loader): change timing to 1.5s per convo with design team --------- Co-authored-by: Julian Skinner <[email protected]> style: updates button font family style: add Faire Spring font family (#1980) Co-authored-by: Julian Skinner <[email protected]> style(button): change button font-weight to med (500) (#1984) Co-authored-by: Julian Skinner <[email protected]> fix(button): loading button wasn't animating, updated svg in button-spinner.js (#1987) Co-authored-by: Julian Skinner <[email protected]> feat: v1.1 rebrand style: update size of font in table (#1986) style: convert focus to focus-within (#1985) style: update color token name 3 digits (#1955) * fix(frame): add box shadow to bordered frame (#1958) * style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter * fix: change legacy colors to mapped values ie red 500 to red 95 * fix: remove old 100 tokens * fix: add 0 to make token 3 digits * fix: add red color classes * fix: add 0 to green color token names * fix: add 0 to blue color token names * fix: add 0 to mercury color token names * fix: add 0 to yellow color token names * fix: add 0 to purple color token names * fix: update grey color token names to 3 digits * fix: update react green colors * fix: update react purple colors * fix: update red in jsx and erb * fix: update orange color token to mercury * fix: update charcoal color token to upper greys * fix: update grey color token to lower greys * fix: add options for default color values * chore: remove whitespace * fix: self review fix grey 300 and grey 400 in css * Revert "fix: self review fix grey 300 and grey 400 in css" This reverts commit 2ae5967. * Revert "fix: update grey color token to lower greys" This reverts commit 69f8706. * fix: update grey color token to lower greys * Revert "fix: update grey color token to lower greys" This reverts commit 2f43f1d. * style: update purple color token to use three digits * style: update additional 2 digit token value to 3 digit token values * style: added zero to mercury 30 * style: update templating to wrap 050 values in single-quotes * style(breadcrumbs): change charcoal 400 to grey 900 * fix: update gray to grey instances --------- Co-authored-by: Julian Skinner <[email protected]> style: update hover color (#1991) style: adjust box shadow (#1992) style: update hint font-size (#1994) fix: adjust token color (#1995) fix: adjust token color (#1997) docs: fix foundations color page fix: correct progress color tokens (#1998) * fix: correct color tokens * docs: update value in react story fix: update token value (#1999) * ci: cleanup and prepare for release * chore: bump @pine-ds/icons to 8.6.0 --------- Co-authored-by: Julian Skinner <[email protected]>

* fix(frame): add box shadow to bordered frame (#1958) * style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter * fix: change legacy colors to mapped values ie red 500 to red 95 * fix: remove old 100 tokens * fix: add 0 to make token 3 digits * fix: add red color classes * fix: add 0 to green color token names * fix: add 0 to blue color token names * fix: add 0 to mercury color token names * fix: add 0 to yellow color token names * fix: add 0 to purple color token names * fix: update grey color token names to 3 digits * fix: update react green colors * fix: update react purple colors * fix: update red in jsx and erb * fix: update orange color token to mercury * fix: update charcoal color token to upper greys * fix: update grey color token to lower greys * fix: add options for default color values * chore: remove whitespace * fix: self review fix grey 300 and grey 400 in css * Revert "fix: self review fix grey 300 and grey 400 in css" This reverts commit 2ae5967. * Revert "fix: update grey color token to lower greys" This reverts commit 69f8706. * fix: update grey color token to lower greys * Revert "fix: update grey color token to lower greys" This reverts commit 2f43f1d. * style: update purple color token to use three digits * style: update additional 2 digit token value to 3 digit token values * style: added zero to mercury 30 * style: update templating to wrap 050 values in single-quotes * style(breadcrumbs): change charcoal 400 to grey 900 * fix: update gray to grey instances --------- Co-authored-by: Julian Skinner <[email protected]>

* feat!(rebrand): mercury-rising rebrand effort ci: update rebrand mercury workflow for deployments revert(font-weight): combine font-weights back to *00 based fix: DSS-752 style(letter-spacing): updates to letter spacing for medium and smaller (#1922) fix: DSS-747 Co-authored-by: Julian Skinner <[email protected]> style: update body-xs to 12px (#1926) refactor: removes page scope empty state and updates styles style: adds styles for Icon Card for default and compact variants style: adds gradient to icon card and empty state docs: removes unneeded examples and adds new props refactor: removes gradient refactor: renames scope prop to size chore: fixes Story name refactor: adds background color to icon docs: updates Empty States docs pages for Rails and React docs: updates React component description with better clarity chore: fixes linting issues chore: removes unneeded gradient references style(alert): adjust small variant icon alignment (#1930) style(checkbox): adjust checkbox margin for alignment (#1931) style(dropdown): add display flex to dropdown trigger (#1934) * style(dropdown): add display flex to dropdown trigger * style(dropdown): reorder css property style(badge): correct interactive icon size (#1935) style(line-height): update line-height to have rem units (#1933) fix(p): remove adjacent p tag spacing (#1936) fix: add white background color to box-like elements * fix(box-shadow): update box shadow token value * fix(box like components): add white background and md box shadow * fix(container): remove color and shadow from container * fix(css): updated order * fix(frame): update to fix background color with nested frames * fix(frame): add white background to bordered variant chore: adds scope prop to address spec failures chore: fixes syntax error fix: add panel box-shadow (#1944) * fix: add box-shadow to panel * fix: remove box-shadow from inner card and panels fix: updates placeholder assets & styles (#1947) * fix: add new image assets * style: adjust page heading image bg color * fix: add new image assets for storybook * fix: convert unsplash images to placeholders * fix: convert unsplash images to small placeholder * fix: hello linter my old friend * fix: update image in empty state fix: update line-height tokens (#1951) fix: update box shadows (#1952) * fix: update box shadows * fix: add space after comma ci: revert rebrand-mercury-rising back to original workflow this is done since release-deploy has been fixed. We hopes this solves this branch from not deploying properly in staging style(pagination): remove background color (#1956) style(choice): correct icon alignment (#1957) * style(choice): remove incorrect margin styles * docs(choice): add additional example without subtext fix(sortable): update template columns (#1960) fix(frame): add box shadow to bordered frame (#1958) style(tab): adjust tab underline variable value (#1959) chore: update pine-ds/icons to latets version fix: updates conditionals to make image optional (#1965) style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter style: change the active tab color to mercury 50 (#1969) Co-authored-by: Julian Skinner <[email protected]> style: focus state updates (#1970) * style: update sage-focus-ring mixin * style: update focus-outline colors * fix: removes duplicate focus ring * style: update focus colors and sizing * style: adjust tab focus * fix: replace named color for linter style(alert): add borders (#1972) style(progress): update the default fill color to mercury-50 (#1971) Co-authored-by: Julian Skinner <[email protected]> style(button): change border radius to 9999px (#1973) Co-authored-by: Julian Skinner <[email protected]> style: update spacer to use logical properties (#1968) style(button): change the colors for the accent variant to be purple (#1974) Co-authored-by: Julian Skinner <[email protected]> feature(loader): change loader to new behavior and colors (#1975) * feat(loader-rails): change the loader animation and fill color * feat(loader-react): change the loader animation and fill color * style(loader): change timing to 1.5s per convo with design team --------- Co-authored-by: Julian Skinner <[email protected]> style: updates button font family style: add Faire Spring font family (#1980) Co-authored-by: Julian Skinner <[email protected]> style(button): change button font-weight to med (500) (#1984) Co-authored-by: Julian Skinner <[email protected]> fix(button): loading button wasn't animating, updated svg in button-spinner.js (#1987) Co-authored-by: Julian Skinner <[email protected]> * style: update color token name 3 digits (#1955) * fix(frame): add box shadow to bordered frame (#1958) * style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter * fix: change legacy colors to mapped values ie red 500 to red 95 * fix: remove old 100 tokens * fix: add 0 to make token 3 digits * fix: add red color classes * fix: add 0 to green color token names * fix: add 0 to blue color token names * fix: add 0 to mercury color token names * fix: add 0 to yellow color token names * fix: add 0 to purple color token names * fix: update grey color token names to 3 digits * fix: update react green colors * fix: update react purple colors * fix: update red in jsx and erb * fix: update orange color token to mercury * fix: update charcoal color token to upper greys * fix: update grey color token to lower greys * fix: add options for default color values * chore: remove whitespace * fix: self review fix grey 300 and grey 400 in css * Revert "fix: self review fix grey 300 and grey 400 in css" This reverts commit 2ae5967. * Revert "fix: update grey color token to lower greys" This reverts commit 69f8706. * fix: update grey color token to lower greys * Revert "fix: update grey color token to lower greys" This reverts commit 2f43f1d. * style: update purple color token to use three digits * style: update additional 2 digit token value to 3 digit token values * style: added zero to mercury 30 * style: update templating to wrap 050 values in single-quotes * style(breadcrumbs): change charcoal 400 to grey 900 * fix: update gray to grey instances --------- Co-authored-by: Julian Skinner <[email protected]> * fix: add-border-to-inner-cards-and-panels * fix: clean up after rebase --------- Co-authored-by: Julian Skinner <[email protected]>

QuintonJason changed the base branch from develop to mercury-rising August 21, 2024 21:58

QuintonJason added the mercury-rising Used for rebrand work label Aug 21, 2024

QuintonJason self-assigned this Aug 21, 2024

ju-Skinner force-pushed the fix/update-color-token-name-3-digits branch from 3a2e43a to b879a8c Compare August 22, 2024 13:54

QuintonJason force-pushed the fix/update-color-token-name-3-digits branch from b879a8c to c5c3b8d Compare August 22, 2024 20:26

ju-Skinner force-pushed the mercury-rising branch 2 times, most recently from c0e3ff2 to ac0f956 Compare September 3, 2024 19:56

ju-Skinner force-pushed the fix/update-color-token-name-3-digits branch from bee88fd to c14c2c6 Compare September 5, 2024 19:22

QuintonJason marked this pull request as ready for review September 5, 2024 23:38

QuintonJason requested a review from a team September 5, 2024 23:38

ju-Skinner reviewed Sep 5, 2024

View reviewed changes

docs/app/views/pages/_color_values.html.erb Outdated Show resolved Hide resolved

ju-Skinner force-pushed the mercury-rising branch from 9c0ad2b to 95af833 Compare September 16, 2024 15:12

QuintonJason force-pushed the fix/update-color-token-name-3-digits branch from 3a4c1b3 to 648a0b4 Compare September 20, 2024 14:16

ju-Skinner changed the title ~~fix/update color token name 3 digits~~ style: update color token name 3 digits Sep 30, 2024

ju-Skinner force-pushed the mercury-rising branch from ea2f1d6 to b922a46 Compare October 1, 2024 04:40

QuintonJason added 4 commits October 1, 2024 13:21

fix(frame): add box shadow to bordered frame (#1958)

2e12557

style: remove border from box like elements with box shadows (#1967)

49951e2

* style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter

fix: change legacy colors to mapped values ie red 500 to red 95

60e8be0

fix: remove old 100 tokens

db39059

ju-Skinner force-pushed the fix/update-color-token-name-3-digits branch 2 times, most recently from 63e4e26 to b4cdd08 Compare October 1, 2024 18:36

ju-Skinner requested review from a team and ju-Skinner October 1, 2024 18:37

QuintonJason added 6 commits October 1, 2024 14:55

fix: add 0 to make token 3 digits

9ca76b3

fix: add red color classes

23ac201

fix: add 0 to green color token names

96dbb7b

fix: add 0 to blue color token names

89cd25d

fix: add 0 to mercury color token names

2b03d37

fix: add 0 to yellow color token names

898a1d0

QuintonJason and others added 5 commits October 1, 2024 14:57

Revert "fix: update grey color token to lower greys"

f297884

This reverts commit 2f43f1d.

style: update purple color token to use three digits

4999217

style: update additional 2 digit token value to 3 digit token values

a72be75

style: added zero to mercury 30

6e6323e

style: update templating to wrap 050 values in single-quotes

cc38799

ju-Skinner force-pushed the fix/update-color-token-name-3-digits branch from b4cdd08 to cc38799 Compare October 1, 2024 19:57

ju-Skinner reviewed Oct 1, 2024

View reviewed changes

packages/sage-assets/lib/stylesheets/components/_breadcrumbs.scss Outdated Show resolved Hide resolved

pixelflips approved these changes Oct 1, 2024

View reviewed changes

pixelflips requested a review from a team October 1, 2024 20:05

ju-Skinner reviewed Oct 1, 2024

View reviewed changes

ju-Skinner requested a review from a team October 1, 2024 20:16

style(breadcrumbs): change charcoal 400 to grey 900

554fa7b

ju-Skinner self-requested a review October 1, 2024 20:28

ju-Skinner approved these changes Oct 1, 2024

View reviewed changes

anechol approved these changes Oct 1, 2024

View reviewed changes

fix: update gray to grey instances

0fd7903

QuintonJason merged commit 284b067 into mercury-rising Oct 2, 2024
4 checks passed

QuintonJason deleted the fix/update-color-token-name-3-digits branch October 2, 2024 00:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

style: update color token name 3 digits #1955

style: update color token name 3 digits #1955

QuintonJason commented Aug 21, 2024 •

edited

Loading

ju-Skinner left a comment •

edited

Loading

ju-Skinner Oct 1, 2024

QuintonJason Oct 1, 2024

anechol left a comment

style: update color token name 3 digits #1955

style: update color token name 3 digits #1955

Conversation

QuintonJason commented Aug 21, 2024 • edited Loading

Description

Screenshots

Testing in sage-lib

Testing in kajabi-products

Related

ju-Skinner left a comment • edited Loading

Choose a reason for hiding this comment

ju-Skinner Oct 1, 2024

Choose a reason for hiding this comment

QuintonJason Oct 1, 2024

Choose a reason for hiding this comment

anechol left a comment

Choose a reason for hiding this comment

QuintonJason commented Aug 21, 2024 •

edited

Loading

Testing in `sage-lib`

Testing in `kajabi-products`

ju-Skinner left a comment •

edited

Loading