Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update documentation for Icons #1928

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

monicawheeler
Copy link
Collaborator

Description

Adjust the location of icons as referenced throughout the documentation

Testing in sage-lib

Copy changes only

Testing in kajabi-products

No external impact. Doc changes only.

@monicawheeler monicawheeler added the documentation Improvements or additions to documentation label Aug 6, 2024
@monicawheeler monicawheeler requested a review from a team August 6, 2024 15:04
@monicawheeler monicawheeler self-assigned this Aug 6, 2024
@pixelflips pixelflips requested a review from a team August 6, 2024 15:05
@ju-Skinner
Copy link
Collaborator

Is this to adjust the text used? However, if it's supposed to reference a new location, then I have an issue because I don't see anything pointing to the new Icon documentation in Pine.

@@ -30,14 +30,14 @@
</tr>
<tr>
<td><%= md('`color`') %></td>
<td><%= md('Which color to use to render the icon. See Sage Colors under "Design."') %></td>
<td><%= md('Which color to use to render the icon. See Sage Colors under "Foundations."') %></td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad to see you added this in. It was a request in Sage Support yesterday.

@monicawheeler
Copy link
Collaborator Author

Is this to adjust the text used? However, if it's supposed to reference a new location, then I have an issue because I don't see anything pointing to the new Icon documentation in Pine.

The updates here were meant to adjust the language to reference “Icons” in the Foundations page. I could clarify that in all areas by saying “See Foundations / Icons”. I also see the need to add information directing users to Pine as well. What do you think?

@ju-Skinner
Copy link
Collaborator

ju-Skinner commented Aug 6, 2024

It was the title of the PR that threw me off. We could add the information to direct them to PIne at a later date.

@monicawheeler monicawheeler changed the title Docs: update location of icons in documentation pages Docs: update documentation for Icons Aug 6, 2024
@monicawheeler monicawheeler merged commit 3c0ad1c into develop Aug 6, 2024
6 checks passed
@monicawheeler monicawheeler deleted the docs/icon-color-documentation branch August 6, 2024 20:54
@pixelflips pixelflips mentioned this pull request Aug 7, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants