-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: update documentation for Icons #1928
Conversation
Is this to adjust the text used? However, if it's supposed to reference a new location, then I have an issue because I don't see anything pointing to the new Icon documentation in Pine. |
@@ -30,14 +30,14 @@ | |||
</tr> | |||
<tr> | |||
<td><%= md('`color`') %></td> | |||
<td><%= md('Which color to use to render the icon. See Sage Colors under "Design."') %></td> | |||
<td><%= md('Which color to use to render the icon. See Sage Colors under "Foundations."') %></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad to see you added this in. It was a request in Sage Support yesterday.
The updates here were meant to adjust the language to reference “Icons” in the Foundations page. I could clarify that in all areas by saying “See Foundations / Icons”. I also see the need to add information directing users to Pine as well. What do you think? |
It was the title of the PR that threw me off. We could add the information to direct them to PIne at a later date. |
Description
Adjust the location of icons as referenced throughout the documentation
Testing in
sage-lib
Copy changes only
Testing in
kajabi-products
No external impact. Doc changes only.