Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert(select): removes size prop from pds-icon #1921

Merged
merged 1 commit into from
Aug 1, 2024
Merged

revert(select): removes size prop from pds-icon #1921

merged 1 commit into from
Aug 1, 2024

Conversation

ju-Skinner
Copy link
Collaborator

Description

Removes using the size attribute to resolve the pds-icon overwritten using the internal style attribute.

Screenshots

No Visual Changes

Testing in sage-lib

  1. Go to Components -> Form Select in Rails Doc.
  2. Navigate to storybook -> Select
  3. In both steps, verify the icon is aligned.

@ju-Skinner ju-Skinner self-assigned this Aug 1, 2024
pixelflips
pixelflips approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ju-Skinner ju-Skinner merged commit 4ac2e57 into develop Aug 1, 2024
6 checks passed
@ju-Skinner ju-Skinner deleted the revert/cleanup-size-props-from-pds-icon-uses branch August 1, 2024 18:23
@ju-Skinner ju-Skinner mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflips pixelflips pixelflips approved these changes

@QuintonJason QuintonJason Awaiting requested review from QuintonJason

@anechol anechol Awaiting requested review from anechol

Assignees

@ju-Skinner ju-Skinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ju-Skinner @pixelflips @kajabi-bot