Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): converts select icon to pds-icon #1918

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Jul 31, 2024

Description

The dropdown icon/arrow is not showing in the Select React component.
This icon was missed during the pds-icon conversion.

Screenshots

Before After
Screenshot 2024-07-31 at 9 54 56 AM Screenshot 2024-07-31 at 9 50 51 AM

Testing in sage-lib

Navigate to Select
Verify icon/arrow is rendering

Testing in kajabi-products

  1. (LOW) Corrects missing arrow icon in the Select React component.

@pixelflips pixelflips self-assigned this Jul 31, 2024
@pixelflips pixelflips requested a review from a team July 31, 2024 17:02
@pixelflips pixelflips marked this pull request as ready for review July 31, 2024 17:02
@monicawheeler monicawheeler requested a review from a team July 31, 2024 17:04
@pixelflips pixelflips merged commit 2347915 into develop Jul 31, 2024
6 checks passed
@pixelflips pixelflips mentioned this pull request Jul 31, 2024
@pixelflips pixelflips changed the title fix: converts select icon to pds-icon fix(select): converts select icon to pds-icon Jul 31, 2024
@pixelflips pixelflips deleted the fix/select-arrow-missing-react branch August 14, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants