Empty State - Style Update and Prop Deprecation #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ju-Skinner
force-pushed
the
mercury-rising
branch
4 times, most recently
from
d8ceef8 to
c264692
Compare
anechol
force-pushed
the
refactor/empty-state-update
branch
from
9e569c6 to
dedaaf9
Compare
anechol
changed the title
ju-Skinner
force-pushed
the
mercury-rising
branch
2 times, most recently
from
a6260eb to
a8ca37e
Compare
anechol
force-pushed
the
refactor/empty-state-update
branch
from
dedaaf9 to
28fab7b
Compare
ju-Skinner
force-pushed
the
mercury-rising
branch
from
7ac8bb2 to
c811884
Compare
anechol
force-pushed
the
refactor/empty-state-update
branch
from
504d035 to
c8a9d09
Compare
ju-Skinner
force-pushed
the
mercury-rising
branch
from
319e941 to
d8e410b
Compare
anechol
force-pushed
the
refactor/empty-state-update
branch
from
791bda1 to
15627c9
Compare
pixelflips
approved these changes
Aug 5, 2024
ju-Skinner
reviewed
Aug 5, 2024
| @@ -4,6 +4,7 @@ class SageIconCard < SageComponent | |||
| background_color: [:optional, NilClass, String], | |||
| color: [:optional, NilClass, SageSchemas::STATUSES], | |||
| foreground_color: [:optional, NilClass, String], | |||
| gradient: [:optional, NilClass, {topColor: String, bottomColor: String}], | |||
There was a problem hiding this comment.
For my own curiousity, how would this work for left to right gradients?
ju-Skinner
requested changes
Aug 5, 2024
anechol
force-pushed
the
refactor/empty-state-update
branch
from
15627c9 to
aa214f9
Compare
ju-Skinner
reviewed
Aug 5, 2024
| @@ -11,6 +11,7 @@ style = { | |||
| sage-icon-card | |||
| <%= "sage-icon-card--#{color}" if color.present? %> | |||
| <%= "sage-icon-card--round" if component.round %> | |||
| <%= "sage-icon-card--gradient" if component.gradient %> | |||
There was a problem hiding this comment.
do we want to have this here, even though we aren't using it?
ju-Skinner
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames the
scopeprop tosizeand updates styles to match Figma.This PR does not include a gradient.
Screenshots
Testing in
sage-libTesting in
kajabi-productsscopeprop tosizeand updates styles to match FigmaRelated
DSS-737