style: update heading font weights #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ju-Skinner
requested review from
pixelflips,
QuintonJason,
anechol and
monicawheeler
ju-Skinner
changed the title
QuintonJason
requested changes
Jul 22, 2024
ju-Skinner
force-pushed
the
mercury-rising
branch
2 times, most recently
from
a9ab6ee to
5b2980d
Compare
QuintonJason
approved these changes
Jul 23, 2024
ju-Skinner
force-pushed
the
style/update-heading-font-weights
branch
from
469cc05 to
b7cc638
Compare
| /// | ||
| /// Sage font weight token utility | ||
| /// | ||
| /// @param {string} $key [regular] The token to retrieve | ||
| /// | ||
| /// @return {number} The value retrieved | ||
| /// | ||
| @function sage-font-weight($key: regular) { | ||
| @function sage-font-weight($key: regular, $heading: false) { |
monicawheeler
approved these changes
Jul 24, 2024
ju-Skinner
added a commit
that referenced
this pull request
Jul 25, 2024
Co-authored-by: Julian Skinner <[email protected]>
ju-Skinner
added a commit
that referenced
this pull request
Jul 26, 2024
Co-authored-by: Julian Skinner <[email protected]>
ju-Skinner
added a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: Julian Skinner <[email protected]>
ju-Skinner
added a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: Julian Skinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Headings will now use 100 based scale (100...900), where the body will now use *25 scale (125...925)
Screenshots
Body - NO CHANGE
Headings
Testing in
sage-libRelated
https://kajabi.atlassian.net/browse/DSS-720