Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: update line height #1909

Merged
merged 1 commit into from
Jul 16, 2024
Merged

style: update line height #1909

merged 1 commit into from
Jul 16, 2024

Conversation

ju-Skinner
Copy link
Collaborator

@ju-Skinner ju-Skinner commented Jul 15, 2024 •
edited
Loading

Description

Adjust the line-height for the body.

Screenshots

Before After
image image

Testing in sage-lib

  1. Navigate to http://localhost:4000/pages/foundations/typography
  2. Inpsect the paragraph tag.

Testing in kajabi-products

  1. (LOW/MEDIUM/HIGH/BREAKING) Description of the change and its impact with QA as the audience.
    • One more examples of the component in use to either test the change or verify the change has not had adverse effects.

Related

https://kajabi.atlassian.net/browse/DSS-713

@ju-Skinner ju-Skinner self-assigned this Jul 15, 2024
@ju-Skinner ju-Skinner changed the base branch from develop to mercury-rising July 15, 2024 19:19
@ju-Skinner ju-Skinner force-pushed the style/update-line-height-dss-713 branch 3 times, most recently from 610ff67 to b09b072 Compare July 16, 2024 00:00
@ju-Skinner ju-Skinner marked this pull request as ready for review July 16, 2024 14:32
QuintonJason
QuintonJason approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@QuintonJason QuintonJason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@ju-Skinner ju-Skinner force-pushed the style/update-line-height-dss-713 branch from b09b072 to 2a4367c Compare July 16, 2024 16:22
@ju-Skinner ju-Skinner force-pushed the style/update-line-height-dss-713 branch from 2a4367c to 5100c90 Compare July 16, 2024 20:23
@ju-Skinner ju-Skinner force-pushed the style/update-line-height-dss-713 branch from 5100c90 to 576ccd4 Compare July 16, 2024 20:26
@ju-Skinner ju-Skinner merged commit 15e2152 into mercury-rising Jul 16, 2024
3 checks passed
@ju-Skinner ju-Skinner deleted the style/update-line-height-dss-713 branch July 16, 2024 21:22
ju-Skinner added a commit that referenced this pull request Jul 23, 2024
@ju-Skinner @kajabi-bot
style: change line-height for body to 1.425 and headings to 1.25 (#1909)
938157e 
Co-authored-by: Julian Skinner <[email protected]>
ju-Skinner added a commit that referenced this pull request Jul 23, 2024
@ju-Skinner @kajabi-bot
style: change line-height for body to 1.425 and headings to 1.25 (#1909)
d131430 
Co-authored-by: Julian Skinner <[email protected]>
@ju-Skinner ju-Skinner added the mercury-rising Used for rebrand work label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anechol anechol anechol approved these changes

@QuintonJason QuintonJason QuintonJason approved these changes

@pixelflips pixelflips pixelflips approved these changes

Assignees

@ju-Skinner ju-Skinner

Labels
mercury-rising Used for rebrand work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ju-Skinner @pixelflips @QuintonJason @anechol @kajabi-bot