fix: update existing core color tokens #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ju-Skinner
approved these changes
Jul 11, 2024
| value: "SageTokens.COLOR_PALETTE.#{color.upcase}_#{value}" | ||
| } %> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Small code refactor...could we make this another partial e.g _color_pallette_body.html.erb? This would allow it to be a simple <% render "color_palette_body", color: color, value: value %> in both areas to reduce duplicity.
There was a problem hiding this comment.
@ju-Skinner great suggestion and definitely reduced the duplication. appreciate it!
| @@ -73,5 +73,24 @@ Reserved for times when something important is missing or for irreversible or de | |||
| Used only when no other color option is available. | |||
| ", use_sage_type: true) %> | |||
| <%= render "color_values", color: "purple"%> | |||
| </div> | |||
|
|
|||
| <div id="deprecated"> | |||
monicawheeler
approved these changes
Jul 11, 2024
ju-Skinner
pushed a commit
that referenced
this pull request
Jul 23, 2024
* fix: update existing core color tokens * fix: update existing core color tokens * fix: updates to color function * docs: implemented branding color changes * style: implemented branding color changes * style: refactored nesting to appease stylelint * docs: created partial for colors to reduce code
ju-Skinner
pushed a commit
that referenced
this pull request
Jul 23, 2024
* fix: update existing core color tokens * fix: update existing core color tokens * fix: updates to color function * docs: implemented branding color changes * style: implemented branding color changes * style: refactored nesting to appease stylelint * docs: created partial for colors to reduce code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new rebranding color tokens and updates current tokens to new values.
Screenshots
Testing in
sage-libNavigate to the colors page. Verify new colors are displayed.
Navigate to Docs Site and Storybook and check for any unexpected color changes.
Testing in
kajabi-productsRelated
https://kajabi.atlassian.net/browse/DSS-668