Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: pds icon style adjustments in buttons #1903

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

pixelflips
Copy link
Member

Description

Updates z-index and pointer-event related styles for pds-icon within buttons.

Screenshots

No visual changes.

Testing in sage-lib

Verify buttons with icons still function as expected.

Testing in kajabi-products

  1. (LOW) Updates z-index and pointer-event for pds-icons in buttons.

Related

N/A

@pixelflips pixelflips self-assigned this Jun 28, 2024
@pixelflips pixelflips marked this pull request as ready for review June 28, 2024 22:56
@pixelflips pixelflips requested review from a team, QuintonJason, ju-Skinner and anechol June 28, 2024 22:56
Copy link
Collaborator

@ju-Skinner ju-Skinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find.

@pixelflips pixelflips merged commit c279013 into develop Jul 1, 2024
6 checks passed
@pixelflips pixelflips mentioned this pull request Jul 1, 2024
@pixelflips pixelflips deleted the style/pds-icon-styling-adjustments branch August 14, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants