Sage: Integrate Pine into icons #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicawheeler
commented
May 17, 2024
monicawheeler
commented
May 17, 2024
monicawheeler
commented
May 17, 2024
monicawheeler
commented
May 17, 2024
monicawheeler
commented
May 17, 2024
monicawheeler
commented
May 17, 2024
monicawheeler
commented
May 17, 2024
monicawheeler
commented
May 17, 2024
monicawheeler
commented
May 17, 2024
monicawheeler
commented
May 17, 2024
pixelflips
force-pushed
the
feature/integrate-pine-icons
branch
from
b94baf6 to
a08ca7b
Compare
ju-Skinner
force-pushed
the
feature/integrate-pine-icons
branch
2 times, most recently
from
1a4f690 to
5b7c438
Compare
ju-Skinner
reviewed
May 28, 2024
anechol
requested changes
May 29, 2024
There was a problem hiding this comment.
Icons are coming in fine in Rails, but I can't see them on the React side. Additionally, because of them being web components, there is now a fraction of a second on page load with no cache where the icon isn't showing up. I can't imagine there will be complaints about it, but just making a note of it here, since this is being updated app-wide.
You will need to be running your local pine for the react side. Also, make sure the ports match your local instance in the |
QuintonJason
requested changes
May 30, 2024
QuintonJason
approved these changes
May 30, 2024
|
@pixelflips - the Category item page has an alert, http://localhost:4000/pages/component/catalog_item?tab=preview, is missing the icon
Others like this: |
|
Property is missing the icons |
|
Typeahead is missing the icons in the dropdown |
|
@monicawheeler those should all be addressed now, docs just had incorrect icon naming. alert icons - done |
|
|
ju-Skinner
force-pushed
the
feature/integrate-pine-icons
branch
from
fdb306f to
6ded28c
Compare
ju-Skinner
force-pushed
the
feature/integrate-pine-icons
branch
from
6ded28c to
4ed3004
Compare
ju-Skinner
pushed a commit
that referenced
this pull request
Jun 7, 2024
* fix: removes dasherize from variable used for attributes (#1893) * chore: update browserslist dependency * fix: removes dasherize variable used for attributes * fix: remove update * fix: adjust id conditional * Sage: Integrate Pine into icons (#1890) * chore: update browserslist dependency * feat: add pine icons to sage * feat(icon): work pine-icon into sage-icon * feat(icon): add pds-icon to both rails and react components * feat: convert rails button icons to pine * fix: correct icon z-index * revert: scripts in manager-head * feat: convert rails icon to pine * fix: add expandable card styles for pds-icon * feat(alert): convert rails icon to pine * fix(avatar): add styles for pds-icon * feat(badge): convert rails icon to pine * feat(banner): convert rails icon to pine * feat(breadcrumbs): convert rails icon to pine * feat(choice): convert rails icon to pine * feat(copytext): convert rails icon to pine * fix(button): add icon for disclosure btn * fix(expandablecard): adjust icon spacing * feat(iconcard): convert rails icon to pine * fix: correct missing icons * feat(forminput): convert rails icon to pine * fix(formsection): correct missing icons * feat(formselect): convert rails icon to pine * fix(formselect): add message icon * feat(textarea): convert rails icon to pine * fix(hint): correct icon alignment * feat(link): convert rails icon to pine * fix: linting errors * ci: add step to configure authToken for NPM * test(react-icon): comment out aria-lable test * feat(navlink): convert rails icon to pine * feat(pageheading): convert help link icon to pine * docs(icon): convert icons to pine * feat(dropdownitem): convert rails icon to pine * feat(search): convert rails icon to pine * feat(statusicon): convert rails icon to pine * feat(sortable): convert rails icon to pine * feat(label): convert rails icon to pine * feat(tab): convert rails icon to pine * fix(tabs): correct icon name typo * fix(search): correct toolbar alignment * fix(catalogitem): fix missing icon * fix: various icon bug fixes * fix(docs): correct home icon * fix(pagination): removes sage icon dependency * feat(toast): convert rails icon to pine * fix: correct linting errors * fix: remove commented code * fix(checkbox): convert check icon to svg * fix(hero): convert play icon to svg * fix(select): update icon-base to include pine * fix: update icon-base to include pine * fix: removes pine-ds/icons as dependency * fix(button): convert classes to tokens * feat(button-react): convert icons to pine * feat(badge-react): convert icons to pine * fix(button-react): convert icon classes to function * fix: correct linter error * fix(choice): update alignments and convert icons * feat(copytext-react): convert icons to pine * feat(link-react): convert icons to pine * feat(link-react): convert icons to pine * style: correct missing semicolon * docs(panel): add icons to preview * fix(badge): change to self closing * feat(toast-react): convert icons to pine * feat(search): convert icons to pine * docs(search): add disabled search preview * fix(icon): adjust text alignment variant * fix: correct linting errors * fix(iconcard): fix sizing and styling issue * fix: search styling adjustments * fix(tag): styling fixes * fix(button): correct type * style: lint fixes * fix: rename icon * fix: correct style syntax * docs: provide additional info in preview-head * feat(property): convert icons to pine * docs: correct icon names * docs: remove legacy instructions * fix: update pds-icon version * feat(banner): add pine icons * fix: correct linting errors * chore: update pine-ds/icons to v7.0.1 --------- Co-authored-by: Julian Skinner <[email protected]> Co-authored-by: Phillip Lovelace <[email protected]> --------- Co-authored-by: Monica Wheeler <[email protected]> Co-authored-by: Julian Skinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates components and documentation to use
pds-icon. Switching over the new icon system should help to eliminate the current manual process.Screenshots
Minimal visual changes should be expected.
Testing in
sage-libTesting in
kajabi-productsRelated
DSS-623