Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dropdown): add horizontal repositioning when space is not available #1822

Merged
merged 4 commits into from
Oct 25, 2023
Merged

fix(dropdown): add horizontal repositioning when space is not available #1822

merged 4 commits into from
Oct 25, 2023

Conversation

QuintonJason
Copy link
Contributor

@QuintonJason QuintonJason commented Oct 18, 2023 •
edited by jira bot
Loading

Description

  • Rails dropdown update horizontal repositioning so that modal doesn't hang off the screen
  • React dropdownupdate horizontal repositioning so that modal doesn't hang off the screen

Screenshots

Rails

Kapture 2023-10-18 at 16 24 48

React

Kapture 2023-10-18 at 17 04 01

Testing in sage-lib

Testing in kajabi-products

  1. (HIGH) Updates the dropdown positioning function include horizontal repositioning.

Related

Closes DSS-477

@QuintonJason QuintonJason changed the title Dss 477/dropdown horizontal and vertical repositioning fix(dropdown): add horizontal repositioning when space is not available Oct 19, 2023
@QuintonJason QuintonJason marked this pull request as ready for review October 19, 2023 13:29
@QuintonJason QuintonJason self-assigned this Oct 19, 2023
@QuintonJason QuintonJason requested a review from a team October 19, 2023 13:29
ju-Skinner
ju-Skinner requested changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@ju-Skinner ju-Skinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the whitespace issues. Other than that things are good.

pixelflips
pixelflips approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of console.log and the whitespace mentioned by Julian, otherwise great work!

packages/sage-system/lib/dropdown.js Outdated Show resolved Hide resolved
@ju-Skinner ju-Skinner requested a review from a team October 24, 2023 14:08
anechol
anechol approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@anechol anechol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@QuintonJason QuintonJason force-pushed the DSS-477/dropdown-horizontal-and-vertical-repositioning branch from 91cd220 to 80c7d50 Compare October 25, 2023 16:35
@QuintonJason QuintonJason mentioned this pull request Oct 25, 2023
Merged
5 tasks
@QuintonJason QuintonJason merged commit fcf5537 into develop Oct 25, 2023
4 checks passed
@QuintonJason QuintonJason deleted the DSS-477/dropdown-horizontal-and-vertical-repositioning branch October 25, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anechol anechol anechol approved these changes

@ju-Skinner ju-Skinner ju-Skinner approved these changes

@pixelflips pixelflips pixelflips approved these changes

Assignees

@QuintonJason QuintonJason

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuintonJason @pixelflips @ju-Skinner @anechol