Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip): DSSINBOX-4 resolve tooltip not removing #1814

Merged
merged 2 commits into from
Oct 18, 2023
Merged

fix(tooltip): DSSINBOX-4 resolve tooltip not removing #1814

merged 2 commits into from
Oct 18, 2023

Conversation

QuintonJason
Copy link
Contributor

@QuintonJason QuintonJason commented Oct 16, 2023 •
edited
Loading

Description

  • resolve bug where tooltip is not removing because mouseleave isn't getting fired on when the trigger is removed from the DOM

Screenshots

Vid of Tooltip fix
https://github.com/Kajabi/sage-lib/assets/1241836/e2ad5348-50d4-42c7-8a8d-c6f10d3b3994

Testing in sage-lib

  • Visit the Tooltip Rails page
  • Verify that clicking on a tooltip trigger closes the tooltip content in addition to hovering

Testing in kajabi-products

  1. (LOW) Update removeTooltip to occur on Tooltip click .

Related

Closes DSSINBOX-4

@QuintonJason QuintonJason self-assigned this Oct 16, 2023
@QuintonJason QuintonJason marked this pull request as ready for review October 16, 2023 16:14
@QuintonJason QuintonJason requested review from kellyredding and a team October 16, 2023 16:14
@pixelflips
Copy link
Member

@QuintonJason I think the yarn.lock was included in your commit.

kellyredding
kellyredding reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@kellyredding kellyredding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuintonJason thanks so much for this! ❤️

@QuintonJason
Copy link
Contributor Author

@QuintonJason I think the yarn.lock was included in your commit.

Updated, but there's a whitespace change I can't get rid of

pixelflips
pixelflips approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@pixelflips pixelflips requested a review from a team October 16, 2023 20:15
@ju-Skinner ju-Skinner changed the title fix(tooltip): DSSINBOX resolve tooltip not removing fix(tooltip): DSSINBOX-4 resolve tooltip not removing Oct 17, 2023
@QuintonJason QuintonJason force-pushed the DSSINBOX-4/tooltip-onclick-prop branch from 8c18ea2 to 0a812f7 Compare October 18, 2023 14:48
@QuintonJason QuintonJason merged commit d8becb1 into develop Oct 18, 2023
4 checks passed
@QuintonJason QuintonJason deleted the DSSINBOX-4/tooltip-onclick-prop branch October 18, 2023 14:54
@QuintonJason QuintonJason mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellyredding kellyredding kellyredding left review comments

@ju-Skinner ju-Skinner ju-Skinner approved these changes

@pixelflips pixelflips pixelflips approved these changes

Assignees

@QuintonJason QuintonJason

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuintonJason @pixelflips @kellyredding @ju-Skinner