Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE][DSS-29] ongoing feedback display #1686

Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

teenwolfblitzer
Copy link
Member

@teenwolfblitzer teenwolfblitzer commented Feb 7, 2023

Description

Documentation changes to improve feedback collection and wayfinding. See discovery doc for additional details.

These changes are intended as a stopgap while focus moves to Pine. Full implementation of the revised documentation site design is a much larger lift.

Support

  • Standardized support and feedback language
    • New Intro/Getting Started/Feedback pages in Storybook
  • Per-page ratings in footer nav popup dropped due to licensing issues
  • Sidebar "Help & Feedback" support area replaces standalone page

Search

This branch also extends Rails Search queries to include component descriptions. Adds some related results, but scope is still limited compared to Storybook

Wayfinding and navigation

  • Displays active category in global nav
  • Revises icons
    • Aligns mobile nav icons with home page categories
    • Applies icons to sidebar/secondary navigation
  • Indicates deprecated components in sidebar
    • Enabled by setting deprecated in component_helper.rb
  • Revised footer link display
    • Adds icons and separates Sage version from documentation links
  • Corrects mobile nav backdrop z-index

Screenshots

Support view before:

after:

Search results before:

after:

Active nav and sidebar icons before:

after:

Mobile nav backdrop overlap before:

after:

Testing in sage-lib

Testing in kajabi-products

  1. (N/A) Sage documentation only

Related

@teenwolfblitzer teenwolfblitzer added the Do not merge Requirements must be met before merging label Feb 13, 2023
@teenwolfblitzer teenwolfblitzer force-pushed the DSS-29_ongoing-feedback-display branch 3 times, most recently from 7b2770e to 1868065 Compare February 28, 2023 20:28
@teenwolfblitzer teenwolfblitzer force-pushed the DSS-29_ongoing-feedback-display branch from 1868065 to e88e34e Compare March 1, 2023 23:19
@teenwolfblitzer teenwolfblitzer force-pushed the DSS-29_ongoing-feedback-display branch 2 times, most recently from 49d1389 to 79b5e21 Compare April 11, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not merge Requirements must be met before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant