Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiscale VO darkening transparent windows when used with new freeIVA depth masks #31

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

LGhassen
Copy link
Collaborator

@LGhassen LGhassen commented Oct 30, 2024

Fix artifacts with MSVO darkening transparent windows seen here: LGhassen/Deferred#47

The fix is simple:

  • MSVO writes to the occlusion channel AFTER deferred reads from it, move it up earlier to the event "BeforeReflections" so deferred can read what it writes
  • MSVO manually darkens the emission/previous camera output on texels with depth, that's not needed in deferred, get rid of it by not binding it as second rendertarget

These fixes only affect deferred rendering. I have tested but didn't do long play sessions so please review and test

@LGhassen LGhassen added the bug Something isn't working label Oct 30, 2024
@LGhassen LGhassen force-pushed the fix-multiscale-vo-depth-masks branch from e9c89ae to 68e16bd Compare October 30, 2024 20:56
@JonnyOThan
Copy link
Member

Does this change still work outside of deferred?

@LGhassen
Copy link
Collaborator Author

LGhassen commented Nov 1, 2024

Yes, if you look at the changes I've only modified the CompositeAmbientOnly() method and the associated commandBuffer event, both are only used in deferred rendering, so changes don't affect forward rendering

@JonnyOThan JonnyOThan merged commit 8c9e2fc into main Nov 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants