Skip to content

Commit

Permalink
Convert dimensions to rem, remove unnecessary media queries.
Browse files Browse the repository at this point in the history
  • Loading branch information
JuzerShakir committed Dec 28, 2023
1 parent e4b449b commit cc1bcf6
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 16 deletions.
25 changes: 10 additions & 15 deletions app/assets/stylesheets/pages/_home.scss
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@
background-position: center;
padding: 2.5rem 8rem;

&__header-logo {
width: 14rem;
height: 5.5rem;

@media (min-width: 380px) {
width: 20rem;
height: 8rem;
}
}

&__body {
margin-top: 22rem;
letter-spacing: -0.05rem;
Expand Down Expand Up @@ -82,23 +92,13 @@
@include media-breakpoint-down(xl) {
#home {
padding: 2.5rem 6rem;

&__header-logo {
width: 280px;
height: 120px;
}
}
}

// * 991.98px (lg)
@include media-breakpoint-down(lg) {
#home {
padding: 2.2rem 5rem;

&__header-logo {
width: 250px;
height: 100px;
}
}
}

Expand All @@ -113,10 +113,5 @@
@include media-breakpoint-down(sm) {
#home {
padding: 1.5rem 2rem;

&__header-logo {
width: 230px;
height: 90px;
}
}
}
2 changes: 1 addition & 1 deletion app/views/pages/home.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div id="home">
<div id="home__header" class="text-center">
<%= image_tag("fmb-logo-full.png", width: "320", height: "130", alt: "FMB logo", id: "home__header-logo") %>
<%= image_tag("fmb-logo-full.png", alt: "FMB logo", id: "home__header-logo") %>
</div>

<div id="home__body">
Expand Down

0 comments on commit cc1bcf6

Please sign in to comment.