BUG FIX - year & total fields are now read-only

app/controllers/thaalis_controller.rb

@@ -29,7 +29,7 @@ def edit
 
   def create
     @sabeel = Sabeel.find(params[:sabeel_id])
-    @thaali = @sabeel.thaalis.new(thaali_params)
+    @thaali = @sabeel.thaalis.new(create_params)
     @thaali.year = CURR_YR
 
     if @thaali.save
@@ -41,7 +41,7 @@ def create
   end
 
   def update
-    if @thaali.update(thaali_params)
+    if @thaali.update(update_params)
       redirect_to @thaali, success: t(".success")
     else
       render :edit, status: :unprocessable_entity
@@ -103,7 +103,7 @@ def check_thaali_for_current_year
 
   def set_year = @year = params[:year]
 
-  def thaali_params = params.require(:thaali).permit(:number, :size, :total)
+  def create_params = params.require(:thaali).permit(:number, :size, :total)
 
   def turbo_load(thaalis)
     respond_to do |format|
@@ -113,4 +113,6 @@ def turbo_load(thaalis)
       end
     end
   end
+
+  def update_params = params.require(:thaali).permit(:number, :size)
 end

app/models/thaali.rb

@@ -1,4 +1,6 @@
 class Thaali < ApplicationRecord
+  attr_readonly :total, :year
+
   # * Associtions
   belongs_to :sabeel
   has_many :transactions, dependent: :destroy

app/views/thaalis/_form.html.erb

@@ -6,7 +6,7 @@
     <%= f.input :year, disabled: true, input_html: {value: (action_name == "edit") ? @thaali.year : CURR_YR} %>
     <%= f.input :number %>
     <%= f.input :size, collection: SIZES.map { [_1.capitalize, _1] }, as: :radio_buttons %>
-    <%= f.input :total %>
+    <%= f.input :total, disabled: action_name == "edit" %>
     <%= f.button :submit, action_name: %>
   <% end %>
 </div>

config/initializers/new_framework_defaults_7_1.rb

@@ -167,7 +167,7 @@
 # behavior would allow assignment but silently not persist changes to the
 # database.
 #++
-# Rails.application.config.active_record.raise_on_assign_to_attr_readonly = true
+Rails.application.config.active_record.raise_on_assign_to_attr_readonly = true
 
 ###
 # Enable validating only parent-related columns for presence when the parent is mandatory.

config/locales/simple_form.en.yml

@@ -20,6 +20,11 @@ en:
         mobile: "without the country code"
         year: "You cannot change this field"
         name: "between 3 to 35 characters long"
+      thaali:
+        new:
+          total: "Cannot be edited later"
+        edit:
+          total: "You cannot change this field"
       user:
         password: "between 6 to 72 characters long"
         password_confirmation: "should match the password"

spec/models/thaali_spec.rb

@@ -10,6 +10,11 @@
     it { is_expected.to have_many(:transactions).dependent(:destroy) }
   end
 
+  context "with attributes" do
+    it { is_expected.to have_readonly_attribute(:year) }
+    it { is_expected.to have_readonly_attribute(:total) }
+  end
+
   context "when validating" do
     context "with number" do
       it { is_expected.to validate_numericality_of(:number).only_integer.with_message("must be an integer") }