return early if amount entered is nil

JuzerShakir · Nov 10, 2023 · 109238e · 109238e
1 parent 1dface5
commit 109238e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/app/models/transaction.rb b/app/models/transaction.rb
@@ -38,8 +38,8 @@ def should_generate_new_friendly_id?
 
   # * Custom Validations
   def amount_to_be_less_than_balance
-    balance = persisted? ? amount_was + thaali.balance : thaali.balance
     return if amount.nil?
+    balance = persisted? ? amount_was + thaali.balance : thaali.balance
 
     if amount > balance
       errors.add(:amount, "cannot be greater than the balance")