Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gonzalo's email to personal account #18

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

HQ063
Copy link
Collaborator

@HQ063 HQ063 commented Feb 20, 2024

As discussed with @JDutil I'm providing this update to check if I still have access to maintain the gem. As it's open source and I built 90% of it I'd like to keep collaborating on this gem.

@HQ063 HQ063 requested a review from JDutil February 20, 2024 20:54
Copy link
Contributor

@JDutil JDutil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also close out Isaac’s automatic release PR or finish it up?

@@ -6,7 +6,7 @@ Gem::Specification.new do |spec|
spec.name = "contentful_lite"
spec.version = ContentfulLite::VERSION
spec.authors = ["Gonzalo Munoz", "Daniel Lopez"]
spec.email = ["gonzalo.munoz@juul.com", "[email protected]"]
spec.email = ["hq063gon@gmail.com", "[email protected]"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add myself and/or [email protected] so that there’s a current JUUL contact as well.

@JDutil
Copy link
Contributor

JDutil commented Feb 21, 2024

@HQ063 are you able to merge?

@HQ063 HQ063 merged commit e2b22e9 into main Feb 26, 2024
3 checks passed
@HQ063
Copy link
Collaborator Author

HQ063 commented Feb 26, 2024

Merged and closed Isaac's PR. It would have been useful but it was still draft because he was unable to make it work.

@JDutil JDutil deleted the gonzalo/update-gonzalo-email branch February 27, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants