Skip to content

Commit

Permalink
fix: log instead of error when lock status can't be determined
Browse files Browse the repository at this point in the history
  • Loading branch information
Justintime50 committed Jan 2, 2023
1 parent a97da9f commit 65b9801
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
# CHANGELOG

## Next Release
## v0.22.1 (2022-12-01)

- Adds a try/catch block to the spawned thread in an attempt to kill off failed deployments
- Moves database logic to adopt the `repos` pattern to separate their logic from the rest of the service
- Adds a script to fail `In-Progress` deployments
- Changes the verbose webhook body debug logger to an info logger that only says which repos the webhook originated from
- Log 500 error messages correctly when an endpoint is hit (previously some errors weren't ever bubbling up and were suppressed or lost)
- Don't throw an error when a lock cannot be looked up for a project, log instead (allows for first-time deploys)
- Various other bug fixes and improvements

## v0.22.0 (2022-11-28)
Expand Down
2 changes: 1 addition & 1 deletion harvey/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class Config:
# Harvey settings
host = os.getenv('HOST', '127.0.0.1')
port = int(os.getenv('PORT', 5000))
harvey_version = '0.22.0'
harvey_version = '0.22.1'
supported_deployments = {
'deploy',
'pull',
Expand Down
6 changes: 1 addition & 5 deletions harvey/deployments.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,7 @@ def initialize_deployment(webhook: Dict[str, Any]) -> Tuple[Dict[str, Any], str,
webhook,
)
except Exception:
Utils.kill_deployment(
message='Could not determine project lock status!',
webhook=webhook,
raise_error=True,
)
logger.error('Could not determine project lock status!')

start_time = datetime.datetime.utcnow()

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

setuptools.setup(
name='harvey-cd',
version='0.22.0',
version='0.22.1',
description='The lightweight Docker Compose deployment platform.',
long_description=long_description,
long_description_content_type="text/markdown",
Expand Down

0 comments on commit 65b9801

Please sign in to comment.