-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitor incoming trades #3201
Monitor incoming trades #3201
Conversation
Draft, as I am not completely sure about this feature. Waiting for feedback before marking as ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, convert to normal PR when ready to merge @Abrynos
The little feedback I've received so far was positive so I guess if no one else is going to review, we can merge. |
Thanks! 🏆 |
Checklist
Changes
As requested on our community Discord server.
New functionality
Metrics endpoint now provides information about trades received since last ASF restart.
Changed functionality
None
Removed functionality
None
Additional info
I do not want to include too much information (e.g. which items [marketable, rarity, appid, type, assetid, classid, contextid] were traded) due to performance/memory considerations. As soon as we start adding those details, this will quickly get out of hand.
Thank you for considering the inclusion of this merge request.