Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc. security improvements #3200

Merged
merged 3 commits into from
May 10, 2024
Merged

Misc. security improvements #3200

merged 3 commits into from
May 10, 2024

Conversation

Abrynos
Copy link
Member

@Abrynos Abrynos commented May 4, 2024 •
edited
Loading

Checklist

  • I read and understood the Contributing Guidelines.
  • This is not a duplicate of an existing merge request.
  • I believe this falls into the scope of the project and should be part of the built-in functionality.
  • My code follows the code style of this project.
  • I have added tests to cover my changes, wherever they are necessary.
  • All new and existing tests pass.

Changes

New functionality

Added x-security-critical attribute to openapi schema.

Changed functionality

LicenseID property in global config is not serialized any more when requested via API due to security concerns raised on our community Discord server.

Removed functionality

None

Additional info

Thanks you for considering the inclusion of this merge request.

@Abrynos Abrynos added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels May 4, 2024
JustArchi
JustArchi requested changes May 5, 2024
View reviewed changes
Copy link
Member

@JustArchi JustArchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that LGTM, make it unified with ipc password and web proxy password, add the attribute to web proxy password as well.

ArchiSteamFarm/Storage/GlobalConfig.cs Show resolved Hide resolved
@JustArchi JustArchi removed the 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. label May 5, 2024
@JustArchi JustArchi merged commit 81789c7 into JustArchiNET:main May 10, 2024
20 checks passed
@JustArchi
Copy link
Member

Thanks! 🏆

@Abrynos Abrynos deleted the security branch May 10, 2024 11:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2024
@Abrynos Abrynos added 🏁 Finished Issues marked with this label were finished already and no further work is required on them. and removed 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. labels Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JustArchi JustArchi JustArchi approved these changes

Assignees
No one assigned
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🏁 Finished Issues marked with this label were finished already and no further work is required on them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abrynos @JustArchi