Skip to content

Commit

Permalink
Dockerfiles no longer preview
Browse files Browse the repository at this point in the history
  • Loading branch information
@JustArchi
JustArchi committed Sep 22, 2024
1 parent 1f43d8d commit 8e9a011
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ RUN <<EOF
npm run deploy --no-progress
EOF

FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:9.0-preview${IMAGESUFFIX} AS build-dotnet
FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:9.0${IMAGESUFFIX} AS build-dotnet
ARG CONFIGURATION=Release
ARG TARGETARCH
ARG TARGETOS
Expand Down Expand Up @@ -76,7 +76,7 @@ RUN --mount=type=secret,id=ASF_PRIVATE_SNK --mount=type=secret,id=STEAM_TOKEN_DU
done
EOF

FROM --platform=$TARGETPLATFORM mcr.microsoft.com/dotnet/aspnet:9.0-preview${IMAGESUFFIX} AS runtime
FROM --platform=$TARGETPLATFORM mcr.microsoft.com/dotnet/aspnet:9.0${IMAGESUFFIX} AS runtime

Check warning on line 79 in Dockerfile

View workflow job for this annotation

GitHub Actions / main (Debug, Dockerfile)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 79 in Dockerfile

View workflow job for this annotation

GitHub Actions / main (Release, Dockerfile)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 79 in Dockerfile

View workflow job for this annotation

GitHub Actions / main (Debug, Dockerfile)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 79 in Dockerfile

View workflow job for this annotation

GitHub Actions / main (Release, Dockerfile)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/
ENV ASF_PATH=/app
ENV ASF_USER=asf
ENV ASPNETCORE_URLS=
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.Service
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ RUN <<EOF
npm run deploy --no-progress
EOF

FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:9.0-preview${IMAGESUFFIX} AS build-dotnet
FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:9.0${IMAGESUFFIX} AS build-dotnet
ARG CONFIGURATION=Release
ARG TARGETARCH
ARG TARGETOS
Expand Down Expand Up @@ -76,7 +76,7 @@ RUN --mount=type=secret,id=ASF_PRIVATE_SNK --mount=type=secret,id=STEAM_TOKEN_DU
done
EOF

FROM --platform=$TARGETPLATFORM mcr.microsoft.com/dotnet/runtime-deps:9.0-preview${IMAGESUFFIX} AS runtime
FROM --platform=$TARGETPLATFORM mcr.microsoft.com/dotnet/runtime-deps:9.0${IMAGESUFFIX} AS runtime

Check warning on line 79 in Dockerfile.Service

View workflow job for this annotation

GitHub Actions / main (Debug, Dockerfile.Service)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 79 in Dockerfile.Service

View workflow job for this annotation

GitHub Actions / main (Release, Dockerfile.Service)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 79 in Dockerfile.Service

View workflow job for this annotation

GitHub Actions / main (Debug, Dockerfile.Service)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 79 in Dockerfile.Service

View workflow job for this annotation

GitHub Actions / main (Release, Dockerfile.Service)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/
ENV ASF_PATH=/app
ENV ASF_USER=asf
ENV ASPNETCORE_URLS=
Expand Down

0 comments on commit 8e9a011

Please sign in to comment.