Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Config-Variable gps_accuracy_threshold #1

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

JustAmply
Copy link
Owner

@JustAmply JustAmply commented Jun 8, 2021

The variable gps_accuracy_threshold has not seen any use for a longer time and after some discussion it became clear that the functionality should not be re-implemented.
See why here: home-assistant#47679 (comment)

Last mention of the config-variable in the official user documentation has been removed a while ago in February: home-assistant/home-assistant.io@3b07f98

Proposed change

Cleanup and removal of unused iCloud-config variable gps_accuracy_threshold

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Justus added 7 commits June 8, 2021 18:35
The variable was not being used anymore and the functionality should not be re-implemented.
See why here: home-assistant#47679 (comment)

Last mention of the config-variable in the official user documentation has been removed a while ago in February: home-assistant/home-assistant.io@3b07f98
@JustAmply JustAmply marked this pull request as ready for review June 9, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant