Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ingestCommitRange and ingestEntities endpoints from client #158

Merged
merged 1 commit into from
May 13, 2024

Conversation

Nick-NCSU
Copy link
Contributor

@Nick-NCSU Nick-NCSU commented May 13, 2024

Due to lack of use and value, the following client methods have been removed: ingestCommitRange and ingestEntities

Maybe add, please contact support if you found these methods valuable.

@Nick-NCSU Nick-NCSU requested a review from a team as a code owner May 13, 2024 16:31
@@ -65,6 +65,7 @@ jobs:
if: env.publish == 'true'
env:
NPM_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
publish: ${{ env.publish }}
Copy link
Contributor Author

@Nick-NCSU Nick-NCSU May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus: Declares this env variable so that the GHA linter stops warning that publish might be invalid. Shouldn't have any effect on how this step runs.

@Nick-NCSU Nick-NCSU changed the title Remove unused endpoints from client Remove unused ingestCommitRange and ingestEntities endpoints from client May 13, 2024
@Nick-NCSU Nick-NCSU merged commit 38685eb into main May 13, 2024
9 checks passed
@Nick-NCSU Nick-NCSU deleted the int-10954-remove-unused-endpoints branch May 13, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants