add design document to refactor port config logic #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
reviewed
Mar 18, 2020
| @@ -0,0 +1,36 @@ | |||
| # SONiC Port Configuration Refactor Design # | |||
There was a problem hiding this comment.
I think the changing design part is OK, suggest adding a test plan section
There was a problem hiding this comment.
Added test plan part, please review
keboliu
reviewed
Apr 8, 2020
| @@ -0,0 +1,48 @@ | |||
| # SONiC Port Configuration Refactor Design # | |||
|
|
|||
There was a problem hiding this comment.
sonic-net/sonic-platform-common#72 check this PR, not quite sure whether it's already covered some change?
There was a problem hiding this comment.
I don't understand that PR, it said it support platform.json, but I don't see any code parse platform.json
There was a problem hiding this comment.
then we ignor, I just thought maybe the also made some change.
keboliu
approved these changes
Apr 8, 2020
|
Community PR: sonic-net#613 |
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Mar 23, 2022
Added breakout handling section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.