Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rework properties describing functionality and refactor internals #97

Merged
merged 62 commits into from
Aug 26, 2024

Conversation

Julusian
Copy link
Owner

@Julusian Julusian commented Jul 16, 2024

This performs some large refactoring/reworking of the library that will form the basis of a v7.0 release.

The aim of this is to make non lcd-button controls feel more native, rather than the afterthought that they are. These have all been tacked on in response to new hardware being released.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 56.34146% with 358 lines in your changes missing coverage. Please review.

Project coverage is 54.66%. Comparing base (e0ac909) to head (14a3355).
Report is 1 commits behind head on main.

Files Patch % Lines
...ges/core/src/services/buttonsLcdDisplay/default.ts 58.64% 54 Missing and 1 partial ⚠️
packages/core/src/services/lcdStripDisplay/plus.ts 8.69% 38 Missing and 4 partials ⚠️
packages/core/src/services/input/gen2.ts 35.93% 38 Missing and 3 partials ⚠️
...s/core/src/services/imageWriter/headerGenerator.ts 29.78% 33 Missing ⚠️
packages/core/src/services/lcdStripDisplay/neo.ts 10.81% 30 Missing and 3 partials ⚠️
packages/core/src/proxy.ts 0.00% 32 Missing ⚠️
packages/webhid/src/index.ts 0.00% 26 Missing ⚠️
packages/core/src/models/base.ts 69.81% 12 Missing and 4 partials ⚠️
packages/webhid/src/wrapper.ts 0.00% 10 Missing and 4 partials ⚠️
packages/core/src/services/properties/pedal.ts 7.69% 12 Missing ⚠️
... and 12 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   53.41%   54.66%   +1.24%     
==========================================
  Files          28       38      +10     
  Lines         863     1030     +167     
  Branches       91      125      +34     
==========================================
+ Hits          461      563     +102     
- Misses        402      444      +42     
- Partials        0       23      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian marked this pull request as ready for review August 25, 2024 16:16
It will better allow for considering spacing, and gives the possibility for different button sizes
@Julusian Julusian changed the title v7.0 refactoring/reworking feat!: rework properties describing functionality and refactor internals Aug 26, 2024
@Julusian Julusian merged commit a78c87d into main Aug 26, 2024
11 checks passed
@Julusian Julusian deleted the next branch August 26, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants