-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rework properties describing functionality and refactor internals #97
Conversation
This reverts commit fd8265f. This is better because it avoids needing a polyfill when using it in the browser
Because jest didn't like it the other way..
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 53.41% 54.66% +1.24%
==========================================
Files 28 38 +10
Lines 863 1030 +167
Branches 91 125 +34
==========================================
+ Hits 461 563 +102
- Misses 402 444 +42
- Partials 0 23 +23 ☔ View full report in Codecov by Sentry. |
It will better allow for considering spacing, and gives the possibility for different button sizes
This performs some large refactoring/reworking of the library that will form the basis of a v7.0 release.
The aim of this is to make non lcd-button controls feel more native, rather than the afterthought that they are. These have all been tacked on in response to new hardware being released.