Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use async node-hid #75

Merged
merged 27 commits into from
Nov 29, 2023
Merged

feat: use async node-hid #75

merged 27 commits into from
Nov 29, 2023

Conversation

Julusian
Copy link
Owner

@Julusian Julusian commented Nov 29, 2023

This removes the limit of number of concurrent devices

@Julusian Julusian merged commit 9938244 into main Nov 29, 2023
13 of 14 checks passed
@Julusian Julusian deleted the feat/node-hid-async branch November 29, 2023 23:13
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 52.54237% with 28 lines in your changes missing coverage. Please review.

Project coverage is 54.03%. Comparing base (5573239) to head (64b04b0).
Report is 44 commits behind head on main.

Files Patch % Lines
packages/node/src/device.ts 35.71% 17 Missing and 1 partial ⚠️
packages/webhid/src/index.ts 0.00% 6 Missing ⚠️
packages/node/src/index.ts 91.30% 2 Missing ⚠️
packages/webhid/src/device.ts 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   52.94%   54.03%   +1.09%     
==========================================
  Files          25       25              
  Lines         748      781      +33     
  Branches       84       85       +1     
==========================================
+ Hits          396      422      +26     
- Misses        341      348       +7     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants