Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tutorials code snippets #94

Merged
merged 3 commits into from
Jun 15, 2024
Merged

Conversation

pasq-cat
Copy link
Member

@pasq-cat pasq-cat commented Jun 10, 2024

there was a missing plot in the logit example page and the code snippets missed the listing the libraries needed to run. part of gsoc 24

@pasq-cat pasq-cat linked an issue Jun 10, 2024 that may be closed by this pull request
Copy link
Member

@pat-alt pat-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Pasquale, but the Markdown documents are rendered through Quarto (**.qmd), so any changes should be made there. Will explain during our meeting this morning.

@pasq-cat
Copy link
Member Author

Thanks, Pasquale, but the Markdown documents are rendered through Quarto (**.qmd), so any changes should be made there. Will explain during our meeting this morning.

@pat-alt the page " a note on the priors" is incomplete and the code is hidden. Should i leave it as it is now or i can set the code to be visible?

ps. have you tried some other distribution for the priors? i have read that the normal distribution is not optimal and the student-t distribution gives better results. maybe we can test it later.

@pat-alt
Copy link
Member

pat-alt commented Jun 10, 2024

Feel free to unhide the code, if that makes it clearer.

ps. have you tried some other distribution for the priors? i have read that the normal distribution is not optimal and the student-t distribution gives better results. maybe we can test it later.

I'm not sure how this would work, since we always assume a multivariate Gaussian posterior (see Murphy (2022) chapter 4.6.8.2). But if you have an idea, happy to discuss.

@pasq-cat
Copy link
Member Author

pasq-cat commented Jun 10, 2024

Feel free to unhide the code, if that makes it clearer.

ps. have you tried some other distribution for the priors? i have read that the normal distribution is not optimal and the student-t distribution gives better results. maybe we can test it later.

I'm not sure how this would work, since we always assume a multivariate Gaussian posterior (see Murphy (2022) chapter 4.6.8.2). But if you have an idea, happy to discuss.

yeah i had forgotten the laplace approx is a plugin approximation over a standard nn, rather than a fully bayesian nn.

@pasq-cat
Copy link
Member Author

sorry for the delay but there was an installation issue with vs code jupyter and quarto and the render kept failing

@pasq-cat pasq-cat requested a review from pat-alt June 10, 2024 18:44
Copy link
Member

@pat-alt pat-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pat-alt pat-alt merged commit d7d0ad7 into main Jun 15, 2024
14 checks passed
@pat-alt pat-alt deleted the 93-fixing-code-in-the-tutorials branch June 15, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing code in the tutorials
2 participants