-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Various tweaks to the Rewriters #548
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
037c25b
to
ec0383d
Compare
src/rewriters.jl
Outdated
@@ -195,8 +201,9 @@ function (p::Walk{ord, C, F, false})(x) where {ord, C, F} | |||
if ord === :pre | |||
x = p.rw(x) | |||
end | |||
if iscall(x) | |||
x = p.similarterm(x, operation(x), map(PassThrough(p), unsorted_arguments(x))) | |||
if istree(x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks incorrect right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
~MATCH
slot which holds the whole expression