Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Don't use GPL module when Base.USE_GPL_LIBS=false #535

Merged
merged 6 commits into from
May 25, 2024

Conversation

inkydragon
Copy link
Contributor

The GPL module SparseArrays.CHOLMOD has already been used before the if Base.USE_GPL_LIBS statement.

This results in the error

ERROR: LoadError: UndefVarError: `CHOLMOD` not defined in `SparseArrays`
Stacktrace:

test/spqr.jl Outdated Show resolved Hide resolved
@gitboy16
Copy link

gitboy16 commented May 2, 2024

Is my understanding correct if I say that tests are failing because of method ambiguities between SparseArrays and LinearAlgebra when Aqua.jl runs?

@ViralBShah
Copy link
Member

Should we disable the aqua tests until they run more reliably?

@inkydragon
Copy link
Contributor Author

inkydragon commented May 3, 2024

disable the aqua tests

Or run Aqua tests in a standalone CI job #537

@inkydragon inkydragon closed this May 5, 2024
@inkydragon inkydragon reopened this May 5, 2024
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (3b30333) to head (4098ca4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
+ Coverage   84.05%   84.07%   +0.01%     
==========================================
  Files          12       12              
  Lines        9020     9069      +49     
==========================================
+ Hits         7582     7625      +43     
- Misses       1438     1444       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Member

Is this ok to merge? I assume we need to fix the Aqua tests separately (and those failures are not related to this PR).

@SobhanMP SobhanMP closed this May 21, 2024
@SobhanMP SobhanMP reopened this May 21, 2024
@SobhanMP
Copy link
Member

I don't think anything can cause failure, but it might be a good to also run the tests with USE_GPL_LIB=false...

@dkarrasch
Copy link
Member

I believe the Aqua tests were running reliably. A commit on Julia master introduced method ambiguities that have been resolved meanwhile. They were failing even on the "split Aqua tests" PR. ;-)

test/cholmod.jl Outdated Show resolved Hide resolved
Copy link
Contributor Author

@inkydragon inkydragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply suggestions.

test/cholmod.jl Outdated Show resolved Hide resolved
test/linalg_solvers.jl Outdated Show resolved Hide resolved
test/spqr.jl Outdated Show resolved Hide resolved
test/umfpack.jl Outdated Show resolved Hide resolved
@ViralBShah ViralBShah merged commit 740b82a into JuliaSparse:main May 25, 2024
10 checks passed
@inkydragon inkydragon deleted the no-gpl branch May 25, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants