-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable auto_update_conda #243
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #243 +/- ##
==========================================
+ Coverage 87.43% 87.50% +0.06%
==========================================
Files 1 1
Lines 207 208 +1
==========================================
+ Hits 181 182 +1
Misses 26 26
☔ View full report in Codecov by Sentry. |
Why are the Windows tests failing? |
either .condarc or condarc-julia.yml should work, but it might be more clear to use .condarc in ROOTENV
This reverts commit 49574be.
Windows failed during the installation of miniconda, so I am guessing (tried to check the documentation https://docs.conda.io/projects/conda/en/latest/user-guide/install/windows.html but failed to find related documentation) whether the error is due to the provided PREFIX folder is not empty since I created the file So the updated version is to write the config file |
LGTM. |
Hm, I tested half a hour ago, and turns out that the underlying issue was already fixed somehow: PyCall, PyPlot, and other dependent packages install just fine on GitHub Actions. The same action failed just two weeks ago with the Not sure what changed, and where... |
Probably Conda fixed their packages in the meantime? But I still feel like it is good practice not to upgrade unless the user specifically requests |
The motivations come from #242 and #238, where the error "ResolvePackageNotFound: - conda==23.1.0" is thrown when conda automatically upgrades from 23.1.0 to 23.5.0.
Although I did not quite understand the real logic of the error, one simple workaround is to disable the auto-update of conda, i.e., fix its version.
On the other hand, since the package Conda.jl has already required to install the latest conda release,
Conda.jl/src/Conda.jl
Lines 167 to 179 in fe6c94c
I think the later update by
auto_update_conda
is just minor, like from 23.1.0 to 23.5.0, then disabling such minor aggressive updates should be reasonable. As a byproduct, it can save the upgrade time.