-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove <details>
/ <summary>
css
#290
Conversation
Follow-up from: JuliaPluto#288 (review) Pending: fonsp/Pluto.jl#2814
Thank you for this implementation! begin
struct Foldable{MD}
title::MD
content::MD
end
function Base.show(io, mime::MIME"text/html", fld::Foldable)
write(io,"<details><summary>")
show(io, mime, fld.title)
write(io,"</summary><p>")
show(io, mime, fld.content)
write(io,"</p></details>")
end
end In my case, both parts are usually Markdown. But now that I saw the |
Initially I had hoped to allow arbitrary After a little noodling I've prototyped a pretty simple solution. I'll turn your suggestion into an issue and start a new PR for that feature specifically. Thanks for the extra push to try again! |
With v0.19.39 released this should be ready to go, yeah? Binder doesn't seem to be on the latest Pluto version so it doesn't show up right, but after updating Pluto everything looks good with this branch locally (for all the good that does 🙄) in Firefox and Chrome. |
Great! Looking forward to the merge! |
details
#288 (review)<details>
/<summary>
fonsp/Pluto.jl#2814 (released: v0.19.39)