-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linting tests with Aqua, JET and ExplicitImports, fix bugs #48
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4d86453
Add linting tests
adrhill 23e97e2
Fix compat entries for stdlibs
adrhill 7025b78
Fix bug caught by JET.jl
adrhill 43c9007
Fix typo
adrhill 039f208
Fix type inference
adrhill 09b5170
Gather exports in main file
adrhill 26443dc
Use explicit imports everywhere
adrhill 2ff518b
Bugfix: add missing languages
adrhill 7fe0a0c
More ExplicitImports tests
adrhill d840519
More ExplicitImports fixes
adrhill 56c3240
Remove unused dependencies
adrhill c64f249
Revert const code string
adrhill efbc212
Capitalize Chinese language in example notebook
adrhill 5a15534
Fix `wrap_tex`
adrhill cec1b43
Fix explicit import for FootnotesNumbered
adrhill ce23e74
Revert const code string
adrhill 9a9eae1
Code review: indicate where imports are used
adrhill ec1297c
Review: advertise LaTeXStrings in example notebook
adrhill 1885bdf
Format notebook
adrhill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,57 @@ | ||
module PlutoTeachingTools | ||
|
||
using PlutoUI | ||
using HypertextLiteral # used by aside & present, might be useful elsewhere | ||
using Markdown | ||
using Markdown: @md_str, MD, Admonition, LaTeX | ||
using HypertextLiteral: @htl, @htl_str | ||
using Downloads: download # used in robustlocalresouce.jl | ||
using PlutoUI: Resource, LocalResource # used in robustlocalresouce.jl | ||
using PlutoUI: combine # used in footnotes.jl | ||
using Latexify: latexify # used in latex.jl | ||
|
||
using PlutoLinks: @ingredients # just for @ingredients | ||
using PlutoLinks: @ingredients | ||
export @ingredients | ||
|
||
include("i18n/i18n.jl") # provides framework for multiple language support | ||
include("computational_thinking.jl") # provides common note boxes | ||
include("present.jl") # provides present_button() & ChooseDisplayMode() | ||
include("latex.jl") # provides latexify_md and wrap_tex | ||
include("aside.jl") # provides aside | ||
include("robustlocalresource.jl") # provides RobustLocalResource | ||
include("other.jl") # provides WidthOverDocs() | ||
include("footnotes.jl") # provides FootnotesNumbered() and FootnotesInlineStyleSuperscript() | ||
include("i18n/i18n.jl") # framework for multiple language support | ||
export AbstractLanguage, set_language! | ||
export preferred_text | ||
|
||
include("computational_thinking.jl") | ||
export hint, tip, protip, almost, warning_box, question_box, answer_box, danger, keyconcept | ||
export correct, still_missing, still_nothing, wrong_type | ||
export var_not_defined, func_not_defined, keep_working | ||
export not_defined # deprecated | ||
#export keep_working_if_var_contains_substr | ||
export type_isa, type_eq | ||
export code_for_check_type_funcs | ||
export TODO, nbsp | ||
export blockquote | ||
export display_msg_if_fail | ||
|
||
include("present.jl") | ||
export present_button | ||
export Foldable | ||
export TwoColumn, ThreeColumn | ||
export TwoColumnWideLeft, TwoColumnWideRight | ||
export ChooseDisplayMode # combines present_button and WidthOverDocs | ||
|
||
include("latex.jl") | ||
export latexify_md, wrap_tex | ||
|
||
include("aside.jl") | ||
export aside, set_aside_width | ||
|
||
include("robustlocalresource.jl") | ||
export RobustLocalResource | ||
|
||
include("other.jl") | ||
export WidthOverDocs | ||
export confetti | ||
|
||
include("footnotes.jl") | ||
export FootnotesInlineNumbered | ||
export FootnotesBottomNumbered | ||
export FootnotesNumbered | ||
export FootnotesInlineStyleSuperscript | ||
export FootnotesInlineStyleSubscript | ||
export FootnotesInlineStyleBaseline | ||
|
||
end # module |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does v <0.0.1 mean? Why not just set this to "1"? Same for Markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown.jl and Downloads.jl are standard libraries and used to be coupled to their Julia releases. Now they are stand-alone packages and have version numbers. For backward compatibility, these new compat entries have to include
<0.0.1
. The1
is the latest stable major release of Downloads.jl (currently1.6.0
).You can find out more here: https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958