Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows specific bugs #11

Merged
merged 2 commits into from
Sep 24, 2022
Merged

Windows specific bugs #11

merged 2 commits into from
Sep 24, 2022

Conversation

savq
Copy link
Member

@savq savq commented Sep 22, 2022 •
edited
Loading

  • Fix ECONNRESET bugs by avoiding closing sockets eagerly. Let GC handle it.
  • Use a dedicated message instead of interrupt for Windows (SIGINT will kill a process unconditionally on WIndows)

Closes #8
Closes #12

@savq savq force-pushed the win-sockets branch 3 times, most recently from e547cbc to 169dad3 Compare September 22, 2022 23:58
@savq savq changed the title Win sockets Windows specific bugs Sep 24, 2022
@savq savq marked this pull request as ready for review September 24, 2022 23:13
@savq savq merged commit 06d3327 into main Sep 24, 2022
@fonsp
Copy link
Member

fonsp commented Sep 26, 2022

@fonsp
Copy link
Member

fonsp commented Sep 26, 2022

@savq savq deleted the win-sockets branch September 27, 2022 23:28
@fonsp fonsp added this to the Pluto integration milestone Jan 24, 2023
@fonsp fonsp mentioned this pull request Mar 7, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Pluto integration
Development

Successfully merging this pull request may close these issues.

Malt on Windows Support interrupt on windows 🙌
2 participants
@savq @fonsp