-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Torch] Updated recipe #9785
[Torch] Updated recipe #9785
Conversation
257a506
to
fbaf1dd
Compare
7962da4
to
172225c
Compare
ffc57b4
to
59fd149
Compare
* Changed to provide lazy artifacts. * Replaced CUDA_full sources with CUDA module dependencies (and similar for CUDA 11.3). * Updated cuda-part of script accordingly. * Added xcrun executable for macOS which can handle `--show-sdk-path`. * Using LLVM v13 (on macOS, v17 has issues). * Adding cuda="none" tag to non-CUDA platforms with matching CUDA platforms.
`should_build_platform` returns true, e.g. for "x86_64-linux-gnu-cxx11" when ARGS = ["x86_64-linux-gnu-cxx11-cuda+10.2"].
7bdd1cf
to
a2c72e4
Compare
be2a7d7
to
dadefa6
Compare
@maleadt Does this look alright to you, wrt. CUDA aspects? I.e., using lazy artifacts, and building for With the goal being to have Torch.jl be automatically loadable (also) on x86_64-linux-gnu (for General registration etc.) - while also selecting CUDA artifacts if appropriate (in accordance with the CUDA platform augmentation implementation). |
I think that looks right. Normally you'd use That said, I'm not entirely convinced anymore that unified CPU+GPU artifacts are the best way forward (as opposed to split packages). There's some fragility e.g. with the |
… with cuda="none"
Great, thanks! I was a little unhappy with the handling around those lines anyway (the double I agree that it might be more right to have separate packages... but keeping the current approach for now (to move things forward). |
Hoping for the materialisation of BinaryBuilder2 to bring pkg extensions to Yggdrasil to handle CUDA-variants of JLLs... |
@maleadt So, since Torch_jll depends on CUDNN_jll, which depends on CUDA_Runtime_jll, which in turn depends on CUDA_Driver_jll, is it impossible to get the Tried setting Debugging in https://github.com/stemann/Torch.jl/actions/runs/12233357984/job/34120277156 |
Correct; that's what I meant with #9785 (comment)
|
Updated Torch recipe
--show-sdk-path
.Added comment to fancy_toys.jl
should_build_platform
should_build_platform
returns true, e.g. for"x86_64-linux-gnu-cxx11"
whenARGS = ["x86_64-linux-gnu-cxx11-cuda+10.2"]
.Added NVTX RuntimeDependency